From 48800f8216c5de12ebc0c65dae0fdfbfc4b7dc25 Mon Sep 17 00:00:00 2001 From: snek Date: Tue, 27 Aug 2024 17:52:27 -0700 Subject: [PATCH] disable pointer compression (#1593) --- .gn | 2 ++ src/binding.cc | 8 -------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.gn b/.gn index b184e8f87..cf30151c1 100644 --- a/.gn +++ b/.gn @@ -38,6 +38,8 @@ default_args = { v8_use_external_startup_data = false v8_use_snapshot = true + v8_enable_pointer_compression = false + # This flag speeds up the performance of fork/execve on Linux systems for # embedders which use it (like Node.js). It works by marking the pages that # V8 allocates as MADV_DONTFORK. Without MADV_DONTFORK, the Linux kernel diff --git a/src/binding.cc b/src/binding.cc index d3172827c..1d5a157d3 100644 --- a/src/binding.cc +++ b/src/binding.cc @@ -3367,14 +3367,6 @@ void v8__HeapProfiler__TakeHeapSnapshot(v8::Isolate* isolate, const_cast(snapshot)->Delete(); } -// This is necessary for v8__internal__GetIsolateFromHeapObject() to be -// reliable enough for our purposes. -#if UINTPTR_MAX == 0xffffffffffffffff && \ - !(defined V8_SHARED_RO_HEAP or defined V8_COMPRESS_POINTERS) -#error V8 must be built with either the 'v8_enable_pointer_compression' or \ -'v8_enable_shared_ro_heap' feature enabled. -#endif - v8::Isolate* v8__internal__GetIsolateFromHeapObject(const v8::Data& data) { namespace i = v8::internal; i::Tagged object(reinterpret_cast(data));