Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex expects commit message to end with a . #604

Closed
Th3S4mur41 opened this issue Mar 10, 2025 · 1 comment
Closed

Regex expects commit message to end with a . #604

Th3S4mur41 opened this issue Mar 10, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@Th3S4mur41
Copy link

The current matcher expects the commit message to end with a dot (.).

const bumpFragment = commitMessage.match(/^Bumps .* from (?<from>v?\d[^ ]*) to (?<to>v?\d[^ ]*)\.$/m)

Refering to #595 as an example, the commit message ends with the version number and not a .

The regex should be updated accordingly

const bumpFragment = commitMessage.match(/^Bumps .* from (?<from>v?\d[^ ]*) to (?<to>v?\d[^ ]*)\.?$/m)
@Th3S4mur41
Copy link
Author

Never mind, I got under the impression that the matcher was using the commit title, while it is actually using the commit body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant