When using get() in array the overwrite with -o option is not respected

[ChristianVermeulen]

Deployer Version

v7.5.8

Target OS

OSX 14.6.1 & github actions ubuntu

Which PHP version are you using?

PHP 8.3

Content of deploy.php or deploy.yaml

set('app_env', 'forgot_to_set');
set('array_test', ['key' => get('app_env')]);

Steps to reproduce

Create a test task:

task('test', function (){
    writeln('{{app_env}}');
    writeln(json_encode(get('array_test')));
});

run the test with overwrite option:

vendor/bin/dep test -o app_env=stg

see result:

task test
[10.0.0.5] stg // Correct
[10.0.0.5] {"key":"forgot_to_set"} // Not overwritten

[antonmedv]

vendor/bin/dep test -o app_env=stg

I can see only one variable overwritten

[ChristianVermeulen]

The 2nd one uses the first one, which was overwritten. But within the second one, it was not actually overwritten en keeps its old value instead of the overwritten value. I would expect 'app_env' to be the overwritten value in both cases.

[antonmedv]

I see. The reason is order of evaluation. Your examples is calculated on php loading time. Only after, arguments get parsed. You can delay evaluation of config using callback:

set('app_env', 'forgot_to_set');
set('array_test', function () {
    return ['key' => get('app_env')];
});

[ChristianVermeulen]

Unfortunately that does not work... Here is what I tried:

set('app_env', 'forgot_to_set');
set('get_sentry_config', function () {
    return [
        'organization' => 'xxx',
        'projects' => [
            'xxx',
        ],
        'token' => 'xxx',
        'environment' => get('app_env'),
    ];
});
set('sentry', get('get_sentry_config'));

And ran vendor/bin/dep deploy all -o app_env=stg. Resulted in:

[10.0.0.5] Sentry: Release of version xxx for projects: xxx created successfully.
[10.0.0.5] Sentry: Deployment xxx for environment forgot_to_set created successfully

It still takes the initial value and does not respect the overwrite :(

[antonmedv]

Same goes here:

set('sentry', get('get_sentry_config'));

at this line get sentry config is “materialized”. Wrap it in a function calls

[ChristianVermeulen]

Hmm, it seems that does not do the trick :( Now it simply does not matarialize at all..

set('app_env', 'forgot_to_set');
set('sentry', function () {
    return [
        'organization' => 'xxx',
        'projects' => [
            'xxx',
        ],
        'token' => 'xxx',
        'environment' => get('app_env'),
    ];
});

[antonmedv]

Hmm. Strange.

deployer/contrib/sentry.php

Lines 87 to 95 in a87081f

	$config = array_merge($defaultConfig, (array) get('sentry'));
	array_walk(
	$config,
	static function (&$value) use ($config) {
	if (is_callable($value)) {
	$value = $value($config);
	}
	},
	);

The call to get here should materialize it here.