Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(react-query): react-query version up #384

Merged
merged 3 commits into from
Jan 9, 2024
Merged

refactor(react-query): react-query version up #384

merged 3 commits into from
Jan 9, 2024

Conversation

minsgy
Copy link
Member

@minsgy minsgy commented Jan 8, 2024 •
edited
Loading

๐Ÿ’ก ์™œ PR์„ ์˜ฌ๋ ธ๋‚˜์š”?

  • react-query v5์œผ๋กœ ๋ฒ„์ „์—… ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • useInfiniteQuery์— initialPageParam ์ด๋ผ๋Š” ํ•„์ˆ˜ ๊ฐ’์ด ์ƒ๊ฒผ์Šต๋‹ˆ๋‹ค.

๐Ÿ’ ๋ฌด์—‡์ด ์–ด๋–ป๊ฒŒ ๋ฐ”๋€Œ๋‚˜์š”?

  • ๊ธฐ๋Šฅ์€ ์œ ์ง€๋ฉ๋‹ˆ๋‹ค.

๐Ÿ’ฌ ๋ฆฌ๋ทฐ์–ด๋ถ„๋“ค๊ป˜

  • react-query v5 ์ปจ๋ฒค์…˜์— ๋งž๋„๋ก๋งŒ ์ˆ˜์ •ํ•ด์„œ ์š” ๊ธฐ๋Šฅ์„ ์ œ๋Œ€๋กœ ํ™œ์šฉํ•˜์‹œ๋ ค๋ฉด ๊ฐ ํŽ˜์ด์ง€ ๊ฐœ๋ฐœํ•˜์‹œ๋ฉด์„œ ๊ฐœ์„ ํ•˜์‹œ๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค
  • queryCache๋ฅผ ์ถ”๊ฐ€ํ•ด์„œ ์ „์—ญ ์—๋Ÿฌ๋กœ ์ฒ˜๋ฆฌํ•  ์ˆ˜ ์žˆ๋„๋ก ๊ธฐ๋ฐ˜์€ ๋‹ค์กŒ๋Š”๋ฐ ์š”๊ฑด ์ข€ ์ถ”ํ›„ ์ด์•ผ๊ธฐํ•ด๋ด๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.
  • sentry์™€ ๊ฐ™์€ ์—๋Ÿฌ์ฒ˜๋ฆฌ์—๋„ ์ข‹์„๋“ฏํ•ฉ๋‹ˆ๋‹ค. ใ…Žใ…Ž

@minsgy minsgy requested review from dengoyoon and chaaerim January 8, 2024 15:49
@minsgy minsgy self-assigned this Jan 8, 2024
@LineGu LineGu enabled auto-merge (squash) January 8, 2024 15:49
chaaerim
chaaerim approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@chaaerim chaaerim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฟผ๋ฆฌ ์˜ต์…˜ ๊ฐ์ฒด๋กœ๋„ ๋‹ค ๋ฐ”๊ฟ”์ฃผ์…จ๊ตฐ์š” ๊ตฟ๊ตฟ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!

@LineGu LineGu merged commit 1497244 into dev Jan 9, 2024
2 checks passed
@LineGu LineGu deleted the feat/react-query-v5 branch January 9, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaaerim chaaerim chaaerim approved these changes

@dengoyoon dengoyoon Awaiting requested review from dengoyoon

Assignees

@minsgy minsgy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minsgy @chaaerim @LineGu