Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing): router group + private router 적용 #389

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

minsgy
Copy link
Member

@minsgy minsgy commented Jan 12, 2024

💡 왜 PR을 올렸나요?

  • 모든 페이지의 RouterGroup을 적용했습니다.
  • root template 의존성을 삭제하였습니다.
  • Private Folder를 사용했습니다.

💁 무엇이 어떻게 바뀌나요?

  • 디자인 레퍼런스:
  • 관련 슬랙 링크:

💬 리뷰어분들께

  • 컴포넌트 배럴패턴 쓰면 서버컴포넌트 관련한 에러가 발생하니 조심하십쇼 ㅠ

@minsgy minsgy force-pushed the feature/router-basic branch from 333c2d8 to ac9c784 Compare January 12, 2024 13:08
@minsgy minsgy force-pushed the feature/router-basic branch from ac9c784 to 1406e03 Compare January 12, 2024 13:13
@minsgy minsgy changed the title Feature/router basic feat(routing): router group + private router 적용 Jan 12, 2024
@minsgy minsgy force-pushed the feature/router-basic branch from 32383d9 to 36d8f85 Compare January 12, 2024 13:21
@minsgy minsgy marked this pull request as ready for review January 12, 2024 13:22
@codecov-commenter
Copy link

Codecov Report

Attention: 351 lines in your changes are missing coverage. Please review.

Comparison is base (2440daa) 0.08% compared to head (36d8f85) 0.08%.

Files Patch % Lines
...rc/app/(AppBarHeader)/_components/Appbar/index.tsx 0.00% 116 Missing ⚠️
src/app/layout.tsx 0.00% 24 Missing ⚠️
...nents/OnboardingBottomsheet/OnboardingCarousel.tsx 0.00% 17 Missing ⚠️
src/common/components/BackHeader/index.tsx 0.00% 13 Missing ⚠️
src/app/(AppBarHeader)/layout.tsx 0.00% 12 Missing ⚠️
src/app/(BackHeader)/layout.tsx 0.00% 12 Missing ⚠️
src/app/api/session/route.ts 0.00% 11 Missing ⚠️
next.config.js 0.00% 9 Missing ⚠️
src/common/providers/index.tsx 0.00% 9 Missing ⚠️
...der)/toks-main/_components/CategoryBottomSheet.tsx 0.00% 6 Missing ⚠️
... and 53 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/routing    #389      +/-   ##
==================================================
- Coverage             0.08%   0.08%   -0.01%     
==================================================
  Files                  168     165       -3     
  Lines                 5937    5945       +8     
  Branches               168     165       -3     
==================================================
  Hits                     5       5              
- Misses                5932    5940       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LineGu LineGu merged commit 01bd400 into release/routing Jan 12, 2024
3 checks passed
@LineGu LineGu deleted the feature/router-basic branch January 12, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants