Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next.config.js): add @tanstack/react-query, @tanstack/query-core as transpilePackages's item #409

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Feb 25, 2024

๐Ÿ’ก ์™œ PR์„ ์˜ฌ๋ ธ๋‚˜์š”?

@tanstack/query-core์˜ ์ด์ „ ๋ธŒ๋ผ์šฐ์ € ๋Œ€์‘
https://github.com/TanStack/query/blob/main/packages/query-core/src/queriesObserver.ts#L38-L43
์œ„ ๋งํฌ์˜ private property in object๋ฅผ next.config.js๋กœ ํŠธ๋žœ์ŠคํŒŒ์ผ๋งํ•˜๊ธฐ

๊ด€๋ จ discussion

TanStack/query#6705

๐Ÿ’ฌ ๋ฆฌ๋ทฐ์–ด๋ถ„๋“ค๊ป˜

(์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค.. ์‚ฌ์‹ค ์ง„์งœ ์ž˜ ๋  ์ง€ ์•ˆ๋  ์ง€๋Š” ๋ชจ๋ฅด๊ฒ ์Šต๋‹ˆ๋‹ค... ์‹ค์ œ ์ €๋ฒ„์ „ iOS์—์„œ ํ…Œ์ŠคํŠธ๊ฐ€ ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค)

@manudeli manudeli marked this pull request as ready for review February 25, 2024 15:43
@manudeli manudeli closed this Feb 25, 2024
@manudeli manudeli reopened this Feb 25, 2024
@manudeli manudeli force-pushed the fix/next.config.js/transpilePackages-tanstack-query branch from 9e8b936 to 0078395 Compare February 27, 2024 13:05
Copy link
Member

@minsgy minsgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ‚ค์•ผ.. ๋ฉ‹์ง„ ๊ธฐ์—ฌ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ๐Ÿ‘ ๐Ÿ‘

@manudeli manudeli force-pushed the fix/next.config.js/transpilePackages-tanstack-query branch from 0078395 to 0a61d0c Compare February 27, 2024 13:30
@minsgy
Copy link
Member

minsgy commented Feb 29, 2024

ci๋งŒ ์›Œํฌํ”Œ๋กœ์šฐ ๋Œ๋ ค๋ณด๊ณ  ๋จธ์ง€ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

@minsgy minsgy force-pushed the fix/next.config.js/transpilePackages-tanstack-query branch from 0a61d0c to febe7f4 Compare March 6, 2024 11:09
@minsgy minsgy enabled auto-merge (squash) March 6, 2024 11:10
@minsgy minsgy disabled auto-merge March 6, 2024 14:15
@minsgy minsgy merged commit 9d60e11 into depromeet:dev Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants