-
Notifications
You must be signed in to change notification settings - Fork 108
docs: Add support for emoji reactions to posts. #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MichelMajdalani
wants to merge
12
commits into
deso-protocol:main
Choose a base branch
from
MichelMajdalani:docs-add-emoji-reactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fb4e83e
WIP: Test failing because returning invalid input for valid input
MichelMajdalani 6979acb
[stable] Release 2.2.6
lazynina 4ba4a3a
Fix IsNodeArchival flag to include SyncTypeBlockSync
diamondhands0 fda9a0f
Add support for a Get Single Derived Key endpoint (#393)
lazynina ca20418
Recoverable signatures, Metamask access bytes, unlimited derived keys…
AeonSw4n 1b2170e
Set fork heights for DeSoUnlimitedDerivedKeysBlockHeight (#401)
lazynina 6ab5891
[stable] Release 2.2.7
lazynina 9cd6087
[stable] Release 3.0.0
lazynina def66be
Additional persisting of state and migration checksums (#402)
AeonSw4n fe94137
[stable] Release 3.0.1
lazynina c415754
WIP: add DBAdapter logic
MichelMajdalani 0c71863
Merge branch 'docs-add-emoji-reactions' of https://github.com/MichelM…
MichelMajdalani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -66,6 +66,9 @@ func (bav *UtxoView) FlushToDbWithTxn(txn *badger.Txn, blockHeight uint64) error | |||||
| if err := bav._flushLikeEntriesToDbWithTxn(txn); err != nil { | ||||||
| return err | ||||||
| } | ||||||
| if err := bav._flushReactEntriesToDbWithTxn(txn); err != nil { | ||||||
| return err | ||||||
| } | ||||||
| if err := bav._flushFollowEntriesToDbWithTxn(txn); err != nil { | ||||||
| return err | ||||||
| } | ||||||
|
|
@@ -411,6 +414,53 @@ func (bav *UtxoView) _flushLikeEntriesToDbWithTxn(txn *badger.Txn) error { | |||||
| return nil | ||||||
| } | ||||||
|
|
||||||
| func (bav *UtxoView) _flushReactEntriesToDbWithTxn(txn *badger.Txn) error { | ||||||
|
|
||||||
| // Go through all the entries in the ReactionKeyToReactionEntry map. | ||||||
| for reactKeyIter, reactEntry := range bav.ReactionKeyToReactionEntry { | ||||||
| // Make a copy of the iterator since we make references to it below. | ||||||
| reactKey := reactKeyIter | ||||||
|
|
||||||
| // Sanity-check that the ReactKey computed from the ReactEntry is | ||||||
| // equal to the ReactKey that maps to that entry. | ||||||
| reactKeyInEntry := MakeReactionKey(reactEntry.ReactorPubKey, *reactEntry.ReactedPostHash, reactEntry.ReactEmoji) | ||||||
| if reactKeyInEntry != reactKey { | ||||||
| return fmt.Errorf("_flushReactEntriesToDbWithTxn: ReactEntry has "+ | ||||||
| "ReactKey: %v, which doesn't match the ReactKeyToReactEntry map key %v", | ||||||
| &reactKeyInEntry, &reactKey) | ||||||
| } | ||||||
|
|
||||||
| // Delete the existing mappings in the db for this ReactKey. They will be re-added | ||||||
| // if the corresponding entry in memory has isDeleted=false. | ||||||
| if err := DbDeleteReactMappingsWithTxn( | ||||||
| txn, reactKey.ReactorPubKey[:], reactKey.ReactedPostHash, reactKey.ReactEmoji); err != nil { | ||||||
|
|
||||||
| return errors.Wrapf( | ||||||
| err, "_flushReactEntriesToDbWithTxn: Problem deleting mappings "+ | ||||||
| "for LikeKey: %v: ", &reactKey) | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| // Go through all the entries in the LikeKeyToLikeEntry map. | ||||||
| for _, reactEntry := range bav.ReactionKeyToReactionEntry { | ||||||
|
|
||||||
| if reactEntry.isDeleted { | ||||||
| // If the LikeEntry has isDeleted=true then there's nothing to do because | ||||||
| // we already deleted the entry above. | ||||||
| } else { | ||||||
| // If the LikeEntry has (isDeleted = false) then we put the corresponding | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| // mappings for it into the db. | ||||||
| if err := DbPutReactMappingsWithTxn( | ||||||
| txn, reactEntry.ReactorPubKey, *reactEntry.ReactedPostHash, reactEntry.ReactEmoji); err != nil { | ||||||
|
|
||||||
| return err | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| return nil | ||||||
| } | ||||||
|
|
||||||
| func (bav *UtxoView) _flushFollowEntriesToDbWithTxn(txn *badger.Txn) error { | ||||||
|
|
||||||
| // Go through all the entries in the FollowKeyToFollowEntry map. | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.