SSH Config warnings with Artful Aardvark

[syntacticvexation]

Hi,

I get some warnings doing a git checkout via SSH when using this module under Artful Aardvark. I receive the following:
==> default: /etc/ssh/ssh_config line 22: Unsupported option "rsaauthentication"
==> default: /etc/ssh/ssh_config line 23: Unsupported option "rhostsrsaauthentication"

My understanding is that these options are no longer supported by newer versions of OpenSSH:
https://forum.gitlab.com/t/ssh-unsupported-option-rsaauthentication/11198

Thanks.

[tenwiseman]

Workaround with undef. (ubuntu 20.04 focal fossa)

class { 'ssh_hardening':
client_options  => {
      # Choose acceptable MACs
      'MACs'                      => 'hmac-sha2-512,hmac-sha2-256',
      # RhostsRSAAuthentication & RSAAuthentication are deprecated, so don't set!
      'RhostsRSAAuthentication'   => undef,
      'RSAAuthentication'         => undef,
    },

I also included an augeas step to remove these from ssh_config if something else initially puts them there.

augeas { 'remove_ssh_deprecated options':
    context  => '/files/etc/ssh/ssh_config',
    changes  => [
      "rm RhostsRSAAuthentication",
      "rm RSAAuthentication"
    ],
}