Pre #3
Open
Pre #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates modal buttons to ensure readability
Adds copy as patch command to SCM repo menu
Also opens deep links internally and does not use progress
Adds welcome source and fixes command args being lost Adds event for first time indicator receives data
Completes GLVSC-463
Adds `global.` namespace to global attributes -- non-global prefixed attributes will be removed in the future
* Adds hovers to the Graph (wip) * Bumps graph and suppresses internal tooltips --------- Co-authored-by: Ramin Tadayon <[email protected]>
…itkraken#3357) * Fixes the procedure of refreshing an access token in GK integration (GLVSC-569) * Upgrade the changelog (GLVSC-569)
Makes room for remote/repo name in first row.
…itkraken#3356) Starts using gk.dev’s auth flow first, otherwise check for a local authentication to GitHub and use it if we have access. * Moves Jira authentication to the superclass * Moves getSession and createSession from auth service to auth providers * Wraps supporting of built-in VSCode providers in BuiltInAuthenticationProvider class * Introduces a provider for GitHub integration that uses GK.dev flow and if no success there it tries to check for existing GitHub session * Splits base auth-provider to local and cloud subclasses that implement createSession differently but share the common logic, which is implemented in the base class, of managing the created session * Stops refreshing GitHub tokens because they never expire: sets the expiration period to 1 year from now. * Ensures that manageCloudIntegrations is always called before attempting integration.connect for GitHub * Skips manage integrations page if GitHub is already connected * Uses different keys for cloud and local tokens saved to the secret-storage. Renames keys of cloud tokens saved under local keys. * Deletes only cloud ones on `syncCloudIntegrations`
Props could change because of the `await` calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤ Thank you for contributing to GitLens! ❤
🚨 IMPORTANT 🚨
↑👆 DELETE above before submitting 👆↑
Description
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses