Skip to content

Feature request: Support for API Token via Authorization header? #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
C-Duv opened this issue Dec 16, 2019 · 2 comments · Fixed by #2
Closed

Feature request: Support for API Token via Authorization header? #1

C-Duv opened this issue Dec 16, 2019 · 2 comments · Fixed by #2

Comments

@C-Duv
Copy link

C-Duv commented Dec 16, 2019

Hello,
Have you considered implementing support for API Token authentication via the Authorization header?

@js-timbirkett
Copy link
Contributor

Hey @C-Duv

You're able to use Basic auth with the API tokens too (using the username: api_key) which was why initially I only supported basic auth.

Adding the Authorization header was pretty simple and is available and functioning in: https://pypi.org/project/grafannotate/0.2.2/ with the -k or --api-key command line arguments.

Thanks for the feature request, hope this little cli tool is helping you 😁

@C-Duv
Copy link
Author

C-Duv commented Feb 11, 2020

Thanks for the feature implementation (especially if it was already possible via Basic Auth... 🤦‍♂️) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants