Refactor tool processing in Invoke-OpenAIProvider to use a generic list for improved performance

dfinke · dfinke · commit 5cdc81bac8e6 · 2026-02-11T12:53:58.000-05:00
diff --git a/Providers/OpenAI.ps1 b/Providers/OpenAI.ps1
@@ -38,13 +38,13 @@ function Invoke-OpenAIProvider {
     
     # Process tools: if strings, register them; then convert to provider schema
     if ($Tools) {
-        $toolDefinitions = @()
+        $toolDefinitions = New-Object System.Collections.Generic.List[object]
         foreach ($tool in $Tools) {
             if ($tool -is [string]) {
-                $toolDefinitions += Register-Tool $tool
+                $toolDefinitions.Add((Register-Tool $tool))
             }
             else {
-                $toolDefinitions += $tool
+                $toolDefinitions.Add($tool)
             }
         }
         $Tools = ConvertTo-ProviderToolSchema -Tools $toolDefinitions -Provider openai

Original file line number	Diff line number	Diff line change
`@@ -38,13 +38,13 @@ function Invoke-OpenAIProvider {`
`38`	`38`
`39`	`39`	`# Process tools: if strings, register them; then convert to provider schema`
`40`	`40`	`if ($Tools) {`
`41`		`- $toolDefinitions = @()`
	`41`	`+ $toolDefinitions = New-Object System.Collections.Generic.List[object]`
`42`	`42`	`foreach ($tool in $Tools) {`
`43`	`43`	`if ($tool -is [string]) {`
`44`		`- $toolDefinitions += Register-Tool $tool`
	`44`	`+ $toolDefinitions.Add((Register-Tool $tool))`
`45`	`45`	`}`
`46`	`46`	`else {`
`47`		`- $toolDefinitions += $tool`
	`47`	`+ $toolDefinitions.Add($tool)`
`48`	`48`	`}`
`49`	`49`	`}`
`50`	`50`	`$Tools = ConvertTo-ProviderToolSchema -Tools $toolDefinitions -Provider openai`