Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Option to skip nginx container #610

Open
genseirin opened this issue Oct 7, 2024 · 1 comment
Open

[FR] Option to skip nginx container #610

genseirin opened this issue Oct 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@genseirin
Copy link

Please ensure your feature request is not already on the roadmap or associated with an issue. This can be checked here.

Is your feature request related to a problem? Please describe.
For our server we need to modify docker-compose.base.yml, which wouldn't persist updates.

We are using a server with Plesk where websites are accessible through a ready Nginx reverse proxy. The attempt to connect Nginx to the nginx container failed (The plain HTTP request was sent to HTTPS port) and having two Nginx reverse proxies in series doesn't give any additional value. The solution was actually to add a port to the app container, to let Nginx on the host server connect there directly, and to disable the unused nginx container. Added in docker-compose.base.yml:

 app:
      ports:
        - "127.0.0.1:<exposed port>:8000"

Describe the solution you'd like

This option could be implemented as a new variable in .env that would let you disable the nginx container and expose a port directly from app. The port number could be taken from INTERFACE_HTTPS_PORT or the value of the new variable.

It seems reasonable to offer also a minimal deployment option that avoids duplication, while keeping the current turnkey solution as a default.

Describe alternatives you've considered
Alternatives would be to edit the yaml file after every update, to connect the two reverse proxies in series or to move to a different host server.

@genseirin genseirin added the enhancement New feature or request label Oct 7, 2024
@whikernel
Copy link
Contributor

Hi!

Unless I'm mistaken, one thing you can do is extend the docker-compose.base.yml with your own docker-compose.custom.yml, that would override the exposed ports for the app. That should work and this wouldn't be an issue with future updates.

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants