Skip to content

CMake, C++ and some interface stuff #15

Open

Description

@conradhuebler

Hey guys,

I made some changes in a fork, which might be interesting.

First, I was always unable to compile cpp-d4 on my manajaro system (gcc 12) due to the way cblas was included. This change made it compileable.
https://github.com/conradhuebler/cpp-d4/blob/main/include/dftd_cblas.h#L22
Since mixing C and C++ always confuses me, I don't know how to make it work without this adaption.

Second, I added the CMake build system, hence this project can easily be integrated into other cmake project.

Third, I added some functions to manipulate TMolecule, so no xyz file has to be read.

https://github.com/conradhuebler/cpp-d4/blob/main/include/dftd_geometry.h#L46

I somehow hestitate to just make pull request, but who knows.

Cheers,
Conrad

Activity

  1. marvinfriede commented on Jan 16, 2023

    @marvinfriede
    Member

    Hey Conrad!

    First, I was always unable to compile cpp-d4 on my manajaro system (gcc 12) due to the way cblas was included. This change made it compileable.

    I encountered the same problem when creating a CI workflow and removed this part (9ce9338).

    Second, I added the CMake build system, hence this project can easily be integrated into other cmake project.

    Third, I added some functions to manipulate TMolecule, so no xyz file has to be read.

    Thanks, I think both of these changes can readily be included.

    Best,
    Marvin

  2. linked a pull request that will close this issueCMake and some interface stuff #16on Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions