Fix: Prevent console window flashing on Windows

- Add CREATE_NO_WINDOW flag to all subprocess calls on Windows
- Add --noconsole flag to PyInstaller for extra safety
- Fixes brief command prompt window appearing on startup

Changes:
- network_monitor.py: Use CREATE_NO_WINDOW for ping and ipconfig
- build.py: Add --noconsole flag for Windows builds

Author: dgiovannetti

build.py

@@ -85,6 +85,7 @@ def build_executable():
         '--name=AMI',
         '--windowed',  # No console window
         '--onefile',  # Single executable
+        '--noconsole' if sys.platform == 'win32' else '',  # Extra flag for Windows
         f'--icon={icon_file}' if icon_file.exists() else '',
         '--add-data', f'{config_file}{os.pathsep}.',  # Include config.json
         f'--paths={src_dir}',  # Add src directory to Python path

src/network_monitor.py

@@ -103,10 +103,15 @@ def ping_host(self, host: str, timeout: int = 5) -> PingResult:
                     timeout_ms = str(timeout * 1000)
 
                     # Run ping command
+                    kwargs = {
+                        'capture_output': True,
+                        'text': True,
+                    }
+                    if sys.platform == 'win32':
+                        kwargs['creationflags'] = subprocess.CREATE_NO_WINDOW
                     result = subprocess.run(
                         ['ping', param, '1', timeout_param, timeout_ms, host],
-                        capture_output=True,
-                        text=True,
+                        **kwargs,
                         timeout=timeout + 1
                     )
 
@@ -416,7 +421,7 @@ def _detect_vpn(self, isp_text: Optional[str]) -> Tuple[bool, str]:
                     pass
             elif plat == 'win32':
                 try:
-                    out = subprocess.check_output(['ipconfig', '/all'], text=True, timeout=3, creationflags=0)
+                    out = subprocess.check_output(['ipconfig', '/all'], text=True, timeout=3, creationflags=subprocess.CREATE_NO_WINDOW)
                     patterns = ['TAP', 'TUN', 'WireGuard', 'PPP adapter', 'NordLynx']
                     if any(pat.lower() in out.lower() for pat in patterns):
                         self._last_vpn_status = (True, 'adapter')