Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version to VSCode marketplace #12

Open
EggBaconAndSpam opened this issue Aug 5, 2019 · 8 comments
Open

Publish new version to VSCode marketplace #12

EggBaconAndSpam opened this issue Aug 5, 2019 · 8 comments

Comments

@EggBaconAndSpam
Copy link
Collaborator

The current version is somewhat out of date and doesn't support e.g. annotating let binders.

For the future, is there a way to automate this in some way? Maybe as part of the dhall-haskell (which includes dhall-lsp-server) release cycle?

@PanAeon
Copy link
Collaborator

PanAeon commented Aug 5, 2019

@EggBaconAndSpam Sorry, it's my fault that I didn't do release for so long. I think the good way to automate the release would do something like in https://github.com/scala/vscode-scala-syntax.

The whole idea is that anyone with the write access to repository can do the release. To do the release a maintainer just need to push a git tag with the release version, then CircleCI will build and publish the extension to the marketplace. The security token that needs for the publishing can be stored securely in the CircleCI environmental variables.

If you don't mind, I think I'll take a few days to experiment with the CircleCI. If anything I can quite easily release your changes by hand.

@EggBaconAndSpam
Copy link
Collaborator Author

If you don't mind, I think I'll take a few days to experiment with the CircleCI. If anything I can quite easily release your changes by hand.

Sounds great, thanks!

@EggBaconAndSpam
Copy link
Collaborator Author

@PanAeon any progress on this?

@PanAeon
Copy link
Collaborator

PanAeon commented Aug 14, 2019

@EggBaconAndSpam
Hey, sorry for the delay. I've just published a new version. Now I'm investigating publishing via TravisCI so all contributors with write access could do it.

@EggBaconAndSpam
Copy link
Collaborator Author

Thank you!

@gregziegan
Copy link

👋 we want to use the asciiOnly feature available after 0.4. Anything I can do to help create and publish a release?

@PanAeon
Copy link
Collaborator

PanAeon commented Mar 10, 2020

@thebritican, the asciiOnly option is in the server config, so I think it should work without any client modification (although I haven't tried yet).
As for publishing if you are willing to help maintain this project I can give you publisher rights, as I'm not using dhall at the moment, and don't follow the project development closely. The process itself is just two commands, but we have to manually verify that everything works before publishing.

@sjakobi
Copy link

sjakobi commented Feb 15, 2021

@thebritican Are you still interested in helping maintain this extension?

If so, it would be great if your permissions could be arranged.

(CC @PanAeon, @Gabriel439, @basile-henry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants