Skip to content

Commit c541939

Browse files
andresmrclaude
andcommitted
chore: move the JaCoCo unpin to the coverage PR
The 0.8.10 pin is fatal once enableAndroidTestCoverage is on -- AGP runs JacocoTransform over every androidTest dependency and 0.8.10 cannot instrument byte-buddy 1.17.7 -- so the unpin has to travel with the instrumentation rather than with the harness work. Moved to fix/coverage-measures-real-code (#5087), along with the verification-metadata entries it produced. This branch keeps the pin as develop has it. verifyAll still lists jacocoReport; only the version handling moved. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 05fad07 commit c541939

2 files changed

Lines changed: 4 additions & 43 deletions

File tree

build.gradle.kts

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ allprojects {
6868
resolutionStrategy {
6969
cacheDynamicVersionsFor(10, TimeUnit.MINUTES)
7070
cacheChangingModulesFor(0, TimeUnit.SECONDS)
71+
eachDependency {
72+
if (requested.group == "org.jacoco")
73+
useVersion("0.8.10")
74+
}
7175
}
7276
}
7377

@@ -79,16 +83,6 @@ allprojects {
7983
exclude(group = "org.junit.jupiter")
8084
}
8185

82-
// The jacoco plugin's toolVersion is what governs the report engine -- libs.jacoco is
83-
// only on the buildscript classpath. Left alone it silently falls back to whatever
84-
// version Gradle bundles (0.8.14 today), which is how the catalog's value ends up
85-
// decorative. The removed useVersion("0.8.10") override was what previously forced it.
86-
plugins.withType<org.gradle.testing.jacoco.plugins.JacocoPlugin> {
87-
extensions.configure<org.gradle.testing.jacoco.plugins.JacocoPluginExtension> {
88-
toolVersion = libs.versions.jacoco.get()
89-
}
90-
}
91-
9286
apply(plugin = "org.jlleitschuh.gradle.ktlint")
9387

9488
gradle.projectsEvaluated {

gradle/verification-metadata.xml

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -5612,34 +5612,11 @@
56125612
<sha256 value="32d62211c0a323f50822a750a647c122b2b1b559f63533ea2e324c0324381370" origin="Generated by Gradle"/>
56135613
</artifact>
56145614
</component>
5615-
<component group="org.jacoco" name="org.jacoco.agent" version="0.8.14">
5616-
<artifact name="org.jacoco.agent-0.8.14-runtime.jar">
5617-
<sha256 value="3fb76eea65f81bd9415202bab34b6571728841dff1ab8e6bbe81adc2e299face" origin="Generated by Gradle"/>
5618-
</artifact>
5619-
<artifact name="org.jacoco.agent-0.8.14.jar">
5620-
<sha256 value="20be9853385bdfc65a5929643412d09243d14514304b89ba23a265158cc8792b" origin="Generated by Gradle"/>
5621-
</artifact>
5622-
</component>
5623-
<component group="org.jacoco" name="org.jacoco.agent" version="0.8.15">
5624-
<artifact name="org.jacoco.agent-0.8.15.jar">
5625-
<sha256 value="81607adaa5b03a687a04049dee6b07e9665708c3e6f7b0626892ca9659be587c" origin="Generated by Gradle"/>
5626-
</artifact>
5627-
</component>
56285615
<component group="org.jacoco" name="org.jacoco.ant" version="0.8.10">
56295616
<artifact name="org.jacoco.ant-0.8.10.jar">
56305617
<sha256 value="a7c8dd6741acb337cc0771a9bf176aa67c09a52a6de011eb7a0f5e78c9bd5872" origin="Generated by Gradle"/>
56315618
</artifact>
56325619
</component>
5633-
<component group="org.jacoco" name="org.jacoco.ant" version="0.8.14">
5634-
<artifact name="org.jacoco.ant-0.8.14.jar">
5635-
<sha256 value="9fff68954d5de3aad2bf838eaf886ed67d2c22a2d6c6f095548bade8c45caeae" origin="Generated by Gradle"/>
5636-
</artifact>
5637-
</component>
5638-
<component group="org.jacoco" name="org.jacoco.ant" version="0.8.15">
5639-
<artifact name="org.jacoco.ant-0.8.15.jar">
5640-
<sha256 value="54fb6af97c95352d7deeb49113d7ad63f190eaa8cc9ae8e068fdb2f2a6de009e" origin="Generated by Gradle"/>
5641-
</artifact>
5642-
</component>
56435620
<component group="org.jacoco" name="org.jacoco.core" version="0.8.10">
56445621
<artifact name="org.jacoco.core-0.8.10.jar">
56455622
<sha256 value="e789667d93a7503938ee978ae4fbbc9a1bccda3b546299b24d8550d816d80e08" origin="Generated by Gradle"/>
@@ -5660,16 +5637,6 @@
56605637
<sha256 value="3e35c14f7853c7c88dbe04cf086ee053a5739f419e98009909bbedecddddd50c" origin="Generated by Gradle"/>
56615638
</artifact>
56625639
</component>
5663-
<component group="org.jacoco" name="org.jacoco.report" version="0.8.14">
5664-
<artifact name="org.jacoco.report-0.8.14.jar">
5665-
<sha256 value="a3e2026060ab8b8d5c650706406234bb4c033dfd5376afeb8b1666e8ed27c453" origin="Generated by Gradle"/>
5666-
</artifact>
5667-
</component>
5668-
<component group="org.jacoco" name="org.jacoco.report" version="0.8.15">
5669-
<artifact name="org.jacoco.report-0.8.15.jar">
5670-
<sha256 value="66a79e36edc77a1ebf6689e76a976e12ab4f1af515cbd09555840fba775714f4" origin="Generated by Gradle"/>
5671-
</artifact>
5672-
</component>
56735640
<component group="org.javassist" name="javassist" version="3.30.2-GA">
56745641
<artifact name="javassist-3.30.2-GA.jar">
56755642
<sha256 value="eba37290994b5e4868f3af98ff113f6244a6b099385d9ad46881307d3cb01aaf" origin="Generated by Gradle" reason="A key couldn't be downloaded"/>

0 commit comments

Comments
 (0)