Skip to content

bump KaldiEngine kaldi-active-grammar version to 3.2.0 or newer for improved dependency freedom #398

@starwarswii

Description

@starwarswii

KaldiEngine currently requires kaldi-active-grammar version 3.1.0
https://github.com/dictation-toolbox/dragonfly/blob/master/dragonfly/engines/backend_kaldi/engine.py#L69

kaldi-active-grammar version 3.2.0 was released last month
https://github.com/daanzu/kaldi-active-grammar/releases/tag/v3.2.0
and based on the release description, it seems to mainly just be bugfixes

with some really rudimentary testing, if you force 3.2.0, nothing major seems to break

from dragonfly.engines.backend_kaldi.engine import KaldiEngine
KaldiEngine._required_kag_version = "3.2.0"

it would be beneficial to update the code to allow version 3.2.0. a very useful update in this version is:

  • Relaxed Python package requirements version specifiers for better compatibility

daanzu/kaldi-active-grammar@4c6fb98

this makes it a lot easier to install, e.g. it no longer restricts numpy to ~=1.16 allowing you to use newer numpy versions that have prebuilt binary wheels for platforms like windows

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions