Skip to content

Commit 630ce2c

Browse files
authoredNov 8, 2024··
Recut - codecov in PR, Codespell, release checklist (#136)
* modify codecov.yml, remove .coveragerc, add news * Add news for codecov
1 parent 3352045 commit 630ce2c

File tree

6 files changed

+26
-55
lines changed

6 files changed

+26
-55
lines changed
 

Diff for: ‎.codecov.yml

+11-31
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,14 @@
1-
# codecov can find this file anywhere in the repo, so we don't need to clutter
2-
# the root folder.
3-
#comment: false
4-
5-
codecov:
6-
notify:
7-
require_ci_to_pass: no
8-
91
coverage:
102
status:
11-
patch:
3+
project: # more options at https://docs.codecov.com/docs/commit-status
124
default:
13-
target: '70'
14-
if_no_uploads: error
15-
if_not_found: success
16-
if_ci_failed: failure
17-
project:
18-
default: false
19-
library:
20-
target: auto
21-
if_no_uploads: error
22-
if_not_found: success
23-
if_ci_failed: error
24-
paths: '!*/tests/.*'
25-
26-
tests:
27-
target: 97.9%
28-
paths: '*/tests/.*'
29-
if_not_found: success
30-
31-
flags:
32-
tests:
33-
paths:
34-
- tests/
5+
target: auto # use the coverage from the base commit, fail if coverage is lower
6+
threshold: 0% # allow the coverage to drop by
7+
8+
comment:
9+
layout: " diff, flags, files"
10+
behavior: default
11+
require_changes: false
12+
require_base: false # [true :: must have a base report to post]
13+
require_head: false # [true :: must have a head report to post]
14+
hide_project_coverage: false # [true :: only show coverage on the git diff aka patch coverage]

Diff for: ‎.coveragerc

-13
This file was deleted.

Diff for: ‎.github/ISSUE_TEMPLATE/release_checklist.md

+10-4
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,16 @@ assignees: ""
1313
- [ ] License information is verified as correct. If you are unsure, please comment below.
1414
- [ ] Locally rendered documentation contains all appropriate pages, including API references (check no modules are
1515
missing), tutorials, and other human written text is up-to-date with any changes in the code.
16-
- [ ] Installation instructions in the README, documentation and on the website (e.g., diffpy.org) are updated and
17-
tested
18-
- [ ] Successfully run any tutorial examples or do functional testing in some other way.
16+
- [ ] Installation instructions in the README, documentation and on the website (e.g., diffpy.org) updated.
17+
- [ ] Successfully run any tutorial examples or do functional testing with the latest Python version
1918
- [ ] Grammar and writing quality have been checked (no typos).
2019

2120
Please mention @sbillinge when you are ready for release. Include any additional comments necessary, such as
22-
version information and details about the pre-release.
21+
version information and details about the pre-release here:
22+
23+
### Post-release checklist
24+
25+
Before closing this issue, please complete the following:
26+
27+
- [ ] Run tutorial examples and conduct functional testing using the installation guide in the README.
28+
- [ ] Documentation (README, tutorials, API references, and websites) is deployed without broken links or missing figures.

Diff for: ‎.github/workflows/build-wheel-release-upload.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Release (GitHub/PyPI)
1+
name: Release (GitHub/PyPI) and Deploy Docs
22

33
on:
44
workflow_dispatch:
@@ -8,8 +8,6 @@ on:
88

99
jobs:
1010
release:
11-
permissions:
12-
contents: write
1311
uses: Billingegroup/release-scripts/.github/workflows/_build-wheel-release-upload.yml@v0
1412
with:
1513
project: diffpy.snmf

Diff for: ‎news/codecov.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
**Added:**
22

3-
* Codecov coverage report in PR
3+
* Coverage report in each PR
44

55
**Changed:**
66

Diff for: ‎pyproject.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ authors = [
1111
maintainers = [
1212
{ name="Simon J.L. Billinge group", email="simon.billinge@gmail.com" },
1313
]
14-
description = "A python package implementing the stretched NMF algorithm."
14+
description = "Python package implementing the stretched NMF algorithm."
1515
keywords = ['diffpy', 'PDF']
1616
readme = "README.rst"
1717
requires-python = ">=3.11, <3.14"
@@ -25,9 +25,9 @@ classifiers = [
2525
'Operating System :: Microsoft :: Windows',
2626
'Operating System :: POSIX',
2727
'Operating System :: Unix',
28-
'Programming Language :: Python :: 3.10',
2928
'Programming Language :: Python :: 3.11',
3029
'Programming Language :: Python :: 3.12',
30+
'Programming Language :: Python :: 3.13',
3131
'Topic :: Scientific/Engineering :: Physics',
3232
'Topic :: Scientific/Engineering :: Chemistry',
3333
]
@@ -57,7 +57,7 @@ dependencies = {file = ["requirements/pip.txt"]}
5757
[tool.codespell]
5858
exclude-file = ".codespell/ignore_lines.txt"
5959
ignore-words = ".codespell/ignore_words.txt"
60-
skip = "*.cif"
60+
skip = "*.cif,*.dat"
6161

6262
[tool.black]
6363
line-length = 115

0 commit comments

Comments
 (0)
Please sign in to comment.