Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build requirement on COMAPEO_METRICS_API_KEY #888

Open
gmaclennan opened this issue Dec 10, 2024 · 0 comments
Open

Remove build requirement on COMAPEO_METRICS_API_KEY #888

gmaclennan opened this issue Dec 10, 2024 · 0 comments

Comments

@gmaclennan
Copy link
Member

Currently you are unable to build the app without COMAPEO_METRICS_API_KEY and COMAPEO_METRICS_URL.

Some ideas, feedback welcome:

  1. We expose COMAPEO_METRICS_URL publicly and include it in the app.
  2. We still accept and store metrics payloads without an API key, but tag them as "unauthenticated", and we can add controls to limit storage if this is abused in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmaclennan