Fix deploy translation error

Author: MaitreyaBuddha

.github/workflows/deploy-functions.yml

@@ -44,5 +44,4 @@ jobs:
         uses: ./
         with:
           environment: ${{ github.event.inputs.environment }}
-          service_account_json: ${{ github.event.inputs.environment == 'prod' && secrets.FIREBASE_PROD_SERVICE_ACCOUNT || secrets.FIREBASE_STAGING_SERVICE_ACCOUNT }}
           project_id: ${{ github.event.inputs.environment == 'prod' && 'hello-wisdom-prod' || 'hello-wisdom-staging' }}

README.md

@@ -56,7 +56,6 @@ jobs:
       - uses: ./ # Uses local action for testing
         with:
           environment: ${{ github.event_name == 'push' && github.ref_name || inputs.environment }}
-          service_account_json: ${{ secrets[format('FIREBASE_{0}_SERVICE_ACCOUNT', github.event_name == 'push' && github.ref_name || inputs.environment)] }}
           project_id: ${{ vars[format('FIREBASE_{0}_PROJECT_ID', github.event_name == 'push' && github.ref_name || inputs.environment)] }}
 ```
 
@@ -67,18 +66,21 @@ When using in your own repository, reference a specific version:
   with:
     functions_dir: 'src/functions' # Default is 'functions'
     environment: staging
-    service_account_json: ${{ secrets.FIREBASE_STAGING_SERVICE_ACCOUNT }}
     project_id: my-project-staging
 ```
 
+Note: The action requires the following secrets to be defined in your repository:
+
+- `FIREBASE_STAGING_SERVICE_ACCOUNT`: Service account JSON for staging environment
+- `FIREBASE_PROD_SERVICE_ACCOUNT`: Service account JSON for production environment
+
 ## Inputs
 
-| Input                  | Description                                       | Required | Default     |
-| ---------------------- | ------------------------------------------------- | -------- | ----------- |
-| `functions_dir`        | Directory containing functions and pyproject.toml | No       | `functions` |
-| `environment`          | Environment to deploy to (staging/prod)           | Yes      | N/A         |
-| `service_account_json` | Firebase service account JSON                     | Yes      | N/A         |
-| `project_id`           | Firebase project ID                               | Yes      | N/A         |
+| Input           | Description                                       | Required | Default     |
+| --------------- | ------------------------------------------------- | -------- | ----------- |
+| `functions_dir` | Directory containing functions and pyproject.toml | No       | `functions` |
+| `environment`   | Environment to deploy to (staging/prod)           | Yes      | N/A         |
+| `project_id`    | Firebase project ID                               | Yes      | N/A         |
 
 ## Prerequisites
 

action.yml

@@ -22,9 +22,6 @@ inputs:
     options:
       - staging
       - prod
-  service_account_json:
-    description: 'Firebase service account JSON'
-    required: true
   project_id:
     description: 'Firebase project ID'
     required: true
@@ -56,8 +53,10 @@ runs:
 
     - name: Authenticate with GCP service account key
       shell: bash
+      env:
+        SERVICE_ACCOUNT_JSON: ${{ inputs.environment == 'prod' && secrets.FIREBASE_PROD_SERVICE_ACCOUNT || secrets.FIREBASE_STAGING_SERVICE_ACCOUNT }}
       run: |
-        echo "${{ inputs.service_account_json }}" > service-account.json
+        echo "$SERVICE_ACCOUNT_JSON" > service-account.json
         echo "GOOGLE_APPLICATION_CREDENTIALS=service-account.json" >> $GITHUB_ENV
 
     - name: Authenticate GitHub Actions service account