Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use array_view when std::span exists? #1

Open
JohnyTheCarrot opened this issue Sep 17, 2024 · 1 comment
Open

Why use array_view when std::span exists? #1

JohnyTheCarrot opened this issue Sep 17, 2024 · 1 comment

Comments

@JohnyTheCarrot
Copy link

Hey folks!

I was looking through your code and I noticed your use of your own array_view class, which seems to be an implementation of C++20's std::span.
This raises the question of which standard you guys are targeting, since there does not appear to be much to indicate it.
I have noticed your discord.py which seems to imply C++20 for linux and C++17 otherwise.

I would also like to ask if such perhaps nit-picky glances at your code is welcome, or if it is unnecessary.

Thanks,
Johny

@Atlante45
Copy link
Contributor

Hey Johny!

Thanks for giving the code a read and this is definitely welcomed feedback.
At the moment, we still need to support C++17 on some of our platforms so we couldn't use std::span but we would like to migrate to it eventually.
In retrospect, maybe we should have a dave::span implementation that matches the standard to make migration easier.

We weren't able to open source our build files in this first round but we're planning on generalizing them so they can be added to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants