You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was looking through your code and I noticed your use of your own array_view class, which seems to be an implementation of C++20's std::span.
This raises the question of which standard you guys are targeting, since there does not appear to be much to indicate it.
I have noticed your discord.py which seems to imply C++20 for linux and C++17 otherwise.
I would also like to ask if such perhaps nit-picky glances at your code is welcome, or if it is unnecessary.
Thanks,
Johny
The text was updated successfully, but these errors were encountered:
Thanks for giving the code a read and this is definitely welcomed feedback.
At the moment, we still need to support C++17 on some of our platforms so we couldn't use std::span but we would like to migrate to it eventually.
In retrospect, maybe we should have a dave::span implementation that matches the standard to make migration easier.
We weren't able to open source our build files in this first round but we're planning on generalizing them so they can be added to this repo.
Hey folks!
I was looking through your code and I noticed your use of your own array_view class, which seems to be an implementation of C++20's
std::span
.This raises the question of which standard you guys are targeting, since there does not appear to be much to indicate it.
I have noticed your discord.py which seems to imply C++20 for linux and C++17 otherwise.
I would also like to ask if such perhaps nit-picky glances at your code is welcome, or if it is unnecessary.
Thanks,
Johny
The text was updated successfully, but these errors were encountered: