Commit 195e99a
committed
Hold the global vector cumsum to the tolerance its example allows
CI reached 1.4e-5 on five of 262144 values against the 1e-5 this asserted. The
example holds three of its four variants to 1e-5 and this one to 1e-4, which the
test flattened to 1e-5 for all four.
The looser bound is the right one here: the other three accumulate within a
chunk while this one runs the length of the sequence, and the kernel and the
reference reach the same sum in a different order. The order depends on how the
work divides across cores, which is why 256 elements passed on one machine and
not on the other.1 parent 44dd81f commit 195e99a
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
0 commit comments