allows to disable lake formation

Author: rudolfix

dlt/destinations/impl/athena/athena.py

@@ -348,6 +348,7 @@ def update_stored_schema(
         if (
             self.config.lakeformation_config is not None
             and self.config.lakeformation_config.enabled
+            is not None  # both True and False are actionable
         ):
             self.manage_lf_tags()
         return applied_update

dlt/destinations/impl/athena/configuration.py

@@ -8,7 +8,7 @@
 
 @configspec
 class LakeformationConfig:
-    enabled: bool = False
+    enabled: Optional[bool] = None
     tags: Optional[Dict[str, str]] = None
 
 

tests/load/athena_iceberg/test_lakeformation.py

@@ -186,7 +186,9 @@ def create_pipelines(
     )
     lf_disabled_pipeline = destination_config.setup_pipeline(
         pipeline_name,
-        destination=destination_config.destination_factory(),
+        destination=destination_config.destination_factory(
+            lakeformation_config=LakeformationConfig(enabled=False)
+        ),
         dataset_name=dataset_name,
         staging=staging_destination,
     )

tests/load/pipeline/test_athena.py

@@ -35,12 +35,15 @@
     ),
     ids=lambda x: x.name,
 )
-@pytest.mark.parametrize("lf_enabled", [True, False], ids=["lf-on", "lf-off"])
+@pytest.mark.parametrize(
+    "lf_enabled", [True, False, None], ids=["lf-on", "lf-off", "lf-passthrough"]
+)
 def test_athena_lakeformation_config_gating(
     destination_config: DestinationTestConfiguration, lf_enabled: bool, mocker, monkeypatch
 ) -> None:
     # Configure Lake Formation gating via env (read by client config)
-    monkeypatch.setenv("DESTINATION__LAKEFORMATION_CONFIG__ENABLED", str(lf_enabled))
+    if lf_enabled is not None:
+        monkeypatch.setenv("DESTINATION__LAKEFORMATION_CONFIG__ENABLED", str(lf_enabled))
 
     pipeline = destination_config.setup_pipeline("athena_" + uniq_id(), dev_mode=True)
 
@@ -55,7 +58,8 @@ def test_athena_lakeformation_config_gating(
         )
 
         client.update_stored_schema()
-        if lf_enabled:
+        # disable and enable flag with add / remove tags respectively, None will skip
+        if lf_enabled is not None:
             mocked_manage.assert_called()
         else:
             mocked_manage.assert_not_called()