Translatable - add table indexes back

[phucwan91]

Feature Request

Since the version v3.21.0 these below 2 indexes were removed . However my project uses them a lot!

please add them back OR support a way that users can create indexes depends on their needs

#[ORM\Index(name: 'translations_lookup_idx', columns: ['locale', 'object_class', 'foreign_key'])]
#[ORM\Index(name: 'general_translations_lookup_idx', columns: ['object_class', 'foreign_key'])]

[mbabker]

OR support a way that users can create indexes depends on their needs

You already can by using your own translation entity, see https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/doc/translatable.md#translation-entity for an example. In this way, you can optimize the database schema to your needs (including whatever indexes will perform best for your application).

[phucwan91]

hey, thank you I checked your link you sent BUT my case is using the common table ext_translations

[mbabker]

Doctrine doesn't have a mechanism that would allow this package to add options for users to create their own indexes. So the simplest thing would be to use that mechanism and use your own entity.

Another option (not tested, but in theory should work) is to use an event listener on the ORM's postGenerateSchema event and add the indexes you need. This should work with a Symfony application:

<?php declare(strict_types=1);

namespace App\EventListener;

use Doctrine\Bundle\DoctrineBundle\Attribute\AsDoctrineListener;
use Doctrine\ORM\Tools\Event\GenerateSchemaEventArgs;
use Gedmo\Translatable\Entity\Translation;

#[AsDoctrineListener(event: 'postGenerateSchema')]
final readonly class LotNotificationTrackingSchemaListener
{
    public function postGenerateSchema(GenerateSchemaEventArgs $event): void
    {
        // When using multiple entity managers ignore events that are triggered by other entity managers.
        if ($event->getEntityManager()->getMetadataFactory()->isTransient(Translation::class)) {
            return;
        }

        $schema = $event->getSchema();

        $table = $schema->getTable('ext_translations');
        $table->addIndex(['locale', 'object_class', 'foreign_key'], 'translations_lookup_idx');
        $table->addIndex(['object_class', 'foreign_key'], 'general_translations_lookup_idx');
    }
}

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[phucwan91]

any simpler ways to achieve that ?