Ignore some case for EarlyExit rule

[VincentLanglet]

I have the following method

public function foo(Collection $collection)
{
     $collection->add($this->bar);
     $collection->add($this->bar);

     if ($collection instanceof BOOM) {
          $collection->add($this->some)
     }
}

which reports an error because I didn't use an early exit.

But changing

     if ($collection instanceof BOOM) {
          $collection->add($this->some)
     }

to

     if (! $collection instanceof BOOM) {
          return;
     }

     $collection->add($this->some)

is taking more lines and not really reducing complexity.

Also, I may change later to

public function foo(Collection $collection)
{
     $collection->add($this->bar);
     $collection->add($this->bar);

     if ($collection instanceof Boom) {
          $collection->add($this->some)
     }

     if ($collection instanceof Please) {
          $collection->add($this->thanks)
     }
}

and so on.

The slevomat Early Exit standard has some configuration available
https://github.com/slevomat/coding-standard/blob/master/doc/control-structures.md#slevomatcodingstandardcontrolstructuresearlyexit-

I would say it's better to use some.

[simPod]

I had no idea it had any configuration. Right now I do this 🙃

public function foo(Collection $collection)
{
     $collection->add($this->bar);
     $collection->add($this->bar);

     if ($collection instanceof BOOM) {
          $collection->add($this->some)
     }

     return;
}

[morozov]

I just want to add that the default configuration is insane. Specifically because:

1. In some cases, in order to reduce the number of lines of code it actually increases it.
2. It makes the code looks asymmetric, which makes it hard to read and even harder to maintain. For instance,

    if ($collection instanceof Boom) {
         $collection->add($this->some);
    }
   
    if ($collection instanceof Please) {
         $collection->add($this->thanks);
    }

   becomes

    if ($collection instanceof Boom) {
         $collection->add($this->some);
    }
   
    if (! $collection instanceof Please) {
         return;
    }
   
    $collection->add($this->thanks);

I wasn't aware of the configuration up until today. Would be happy if some sane configuration was applied (e.g. ignoreTrailingIfWithOneInstruction).