Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not differentiate integer/float identifier types #766

Open
jmikola opened this issue Jan 16, 2014 · 0 comments
Open

Do not differentiate integer/float identifier types #766

jmikola opened this issue Jan 16, 2014 · 0 comments
Assignees
Labels

Comments

@jmikola
Copy link
Member

jmikola commented Jan 16, 2014

See #444 (comment):

Don't differentiate between integers and floats (see aa168b1), which will make this consistent with MongoDB's comparison behavior

Beyond that, the only caveat I see is that searching by an integer/float will not find a numeric string, and vice versa. This is evident in the IdTest fix made in aa168b1#L2L84 -- it may bite some users, but I think it's necessary unless we want to seriously complicate the IdType class.

MongoDB considers integers and float types equivalent for purposes of matching and indexing (including uniqueness). We should do the same in UnitOfWork's identity map.

@ghost ghost assigned jmikola Jan 16, 2014
@jmikola jmikola modified the milestones: 1.0.0, 1.0.0-BETA10 Apr 30, 2014
@jmikola jmikola added the Bug label Aug 18, 2015
@jmikola jmikola modified the milestones: 1.x, 1.0.0 Aug 18, 2015
@alcaeus alcaeus modified the milestones: 1.x, 2.x Dec 22, 2017
@alcaeus alcaeus removed this from the 2.x milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants