-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(katana): add chunk size limit for starknet_getEvents
method
#2596
Comments
starknet_getEvents
method
Mind if I take this issue? |
@sajalbnl assigned :) |
Can I start working on this? |
@kariy |
@sajalbnl do you have any progress so far? if not i will reassign the issue |
Gm. I believe they have removed their assignment.. as per the logs above |
@PoulavBhowmick03 ah my bad missed that. assigning it to you then |
Thanks! |
dojo/crates/katana/rpc/rpc/src/starknet/mod.rs
Lines 494 to 513 in 8a9dc0c
we should limit the chunk size to avoid getting dos by giving an insanely large value. the limit should be configurable through the cli
The text was updated successfully, but these errors were encountered: