From 581b2ebddd9a54634b839c90eadb51260d793dd5 Mon Sep 17 00:00:00 2001
From: Dominik Hryshaiev <domhryshaiev@gmail.com>
Date: Sat, 28 Dec 2024 18:25:25 +0200
Subject: [PATCH] feat(calendar): add viewing of occurrence times (#140)

* feat(calendar): add viewing of occurrence times

* style: remove comments
---
 src/components/calendar/OccurrenceChip.tsx    | 97 +++++++------------
 .../habit/habits-page/HabitsPage.tsx          |  4 +-
 src/components/user-account/AccountPage.tsx   |  2 +-
 src/index.css                                 | 11 +++
 supabase/database.types.ts                    |  6 +-
 ...241228160154_non_nullable_note_content.sql |  1 +
 tailwind.config.js                            |  3 -
 7 files changed, 54 insertions(+), 70 deletions(-)
 create mode 100644 supabase/migrations/20241228160154_non_nullable_note_content.sql

diff --git a/src/components/calendar/OccurrenceChip.tsx b/src/components/calendar/OccurrenceChip.tsx
index 0592e3f..87a2fd5 100644
--- a/src/components/calendar/OccurrenceChip.tsx
+++ b/src/components/calendar/OccurrenceChip.tsx
@@ -1,15 +1,9 @@
 import type { Occurrence } from '@models';
-import {
-  Badge,
-  Button,
-  Popover,
-  PopoverContent,
-  PopoverTrigger,
-  Tooltip,
-} from '@nextui-org/react';
-import { Note, Trash } from '@phosphor-icons/react';
+import { Badge, Button, Tooltip } from '@nextui-org/react';
+import { Trash } from '@phosphor-icons/react';
 import { useNotesStore } from '@stores';
 import { getHabitIconUrl } from '@utils';
+import { format } from 'date-fns';
 import React from 'react';
 
 export type OccurrenceChipProps = {
@@ -26,57 +20,51 @@ const OccurrenceChip = ({
   onDelete,
   colorOverride,
 }: OccurrenceChipProps) => {
+  const occurrenceIds = occurrences.map((o) => o.id);
   const [occurrence] = occurrences;
   const { habit } = occurrence;
   const { notes } = useNotesStore();
   const { name: habitName, iconPath, trait } = habit || {};
   const { color: traitColor } = trait || {};
   const iconUrl = getHabitIconUrl(iconPath);
-  const occurrenceNote = notes.find(
-    (note) => note.occurrenceId === occurrences[0].id
+  const occurrenceTimes = occurrences.map((o) => ({
+    occurrenceId: o.id,
+    time: format(new Date(o.timestamp), 'p'),
+  }));
+  const occurrenceNotes = notes.filter(
+    (n) => n.occurrenceId && occurrenceIds.includes(n.occurrenceId)
   );
-  const [isOccurrenceTooltipOpen, setIsOccurrenceTooltipOpen] =
-    React.useState(false);
-  const [isNotePopoverOpen, setIsNotePopoverOpen] = React.useState(false);
 
   const chipStyle = {
     borderColor: colorOverride || traitColor,
   };
 
   const tooltipContent = (
-    <div className="flex items-center justify-between gap-2">
-      {habitName}
-      {occurrenceNote && (
-        <Popover
-          isOpen={isNotePopoverOpen}
-          onOpenChange={(open) => setIsNotePopoverOpen(open)}
+    <div className="space-y-2">
+      <div className="flex items-center justify-between gap-2">
+        <span className="font-bold">{habitName}</span>
+        <Button
+          isIconOnly
+          variant="solid"
+          color="danger"
+          onClick={(clickEvent) => onDelete(occurrences[0].id, clickEvent)}
+          role="habit-chip-delete-button"
+          className="h-6 w-6 min-w-0 rounded-lg"
         >
-          <PopoverTrigger>
-            <Button
-              color="primary"
-              variant="solid"
-              size="sm"
-              isIconOnly
-              className="h-6 w-6 min-w-0 rounded-lg"
-            >
-              <Note />
-            </Button>
-          </PopoverTrigger>
-          <PopoverContent>
-            <p className="text-tiny">{occurrenceNote.content}</p>
-          </PopoverContent>
-        </Popover>
-      )}
-      <Button
-        isIconOnly
-        variant="solid"
-        color="danger"
-        onClick={(clickEvent) => onDelete(occurrences[0].id, clickEvent)}
-        role="habit-chip-delete-button"
-        className="h-6 w-6 min-w-0 rounded-lg"
-      >
-        <Trash size={14} fill="bold" className="fill-white" />
-      </Button>
+          <Trash size={14} fill="bold" className="fill-white" />
+        </Button>
+      </div>
+      <ul className="italic">
+        {occurrenceTimes.map((t) => (
+          <li key={t.occurrenceId}>
+            <span className="font-semibold">{t.time}</span>:{' '}
+            <span className="font-normal">
+              {occurrenceNotes.find((n) => n.occurrenceId === t.occurrenceId)
+                ?.content || 'No note'}
+            </span>
+          </li>
+        ))}
+      </ul>
     </div>
   );
 
@@ -84,19 +72,14 @@ const OccurrenceChip = ({
     const chip = (
       <div
         style={chipStyle}
-        className="relative mr-1 mt-1 min-w-0 rounded-full border-1 bg-slate-100 p-1.5 dark:bg-slate-800"
+        className="relative mr-1 mt-1 min-w-0 rounded-full border-2 bg-slate-100 p-2 dark:bg-slate-800"
         role="habit-chip"
       >
         <img
           src={iconUrl}
           alt={`${habitName} icon`}
-          className="h-4 w-4 rounded"
+          className="h-5 w-5 rounded"
         />
-        {occurrenceNote && (
-          <div className="absolute -right-2 -top-2 text-slate-400">
-            <Note size={16} weight="fill" />
-          </div>
-        )}
       </div>
     );
 
@@ -119,14 +102,6 @@ const OccurrenceChip = ({
 
   return (
     <Tooltip
-      isOpen={isOccurrenceTooltipOpen}
-      onOpenChange={(open) => {
-        if (isNotePopoverOpen && !open) {
-          return;
-        }
-
-        setIsOccurrenceTooltipOpen(open);
-      }}
       isDisabled={!habitName}
       content={tooltipContent}
       radius="sm"
diff --git a/src/components/habit/habits-page/HabitsPage.tsx b/src/components/habit/habits-page/HabitsPage.tsx
index 42403d1..471c694 100644
--- a/src/components/habit/habits-page/HabitsPage.tsx
+++ b/src/components/habit/habits-page/HabitsPage.tsx
@@ -99,7 +99,7 @@ const HabitsPage = () => {
 
   return (
     <div className="contents">
-      <h1 className="font-bold mx-auto my-4 text-3xl text-gray-800 dark:text-gray-300">
+      <h1 className="mx-auto my-4 text-3xl font-bold text-gray-800 dark:text-gray-300">
         Your habits
       </h1>
       <Table className="m-auto w-[95%] lg:w-[80%]">
@@ -127,7 +127,7 @@ const HabitsPage = () => {
               </TableCell>
               <TableCell>
                 <Chip size="sm" variant="faded" className="ml-2 h-5 border-1">
-                  <div className="flex items-center gap-1">
+                  <div className="flex items-center gap-1 font-semibold">
                     <span
                       className="mr-0.5 inline-block h-1 w-1 rounded-full"
                       role="habit-trait-chip-color-indicator"
diff --git a/src/components/user-account/AccountPage.tsx b/src/components/user-account/AccountPage.tsx
index 91ed72c..68471ab 100644
--- a/src/components/user-account/AccountPage.tsx
+++ b/src/components/user-account/AccountPage.tsx
@@ -60,7 +60,7 @@ const AccountPage = () => {
   return (
     <div className="flex h-lvh w-full flex-col items-start self-start pt-8">
       <div className={containerClassName} data-testid="account-page">
-        <h1 className="font-semibold text-xl">Your Account Info</h1>
+        <h1 className="text-xl font-semibold">Your Account Info</h1>
         <form
           className="mt-4 w-[400px]"
           onSubmit={handleSubmit}
diff --git a/src/index.css b/src/index.css
index b5c61c9..44c1846 100644
--- a/src/index.css
+++ b/src/index.css
@@ -1,3 +1,14 @@
 @tailwind base;
 @tailwind components;
 @tailwind utilities;
+
+th,
+td,
+tr,
+button,
+[role='button'],
+[data-slot='value'],
+[data-slot='input'],
+[data-label='true'] {
+  font-weight: 600 !important;
+}
diff --git a/supabase/database.types.ts b/supabase/database.types.ts
index a745706..5570348 100644
--- a/supabase/database.types.ts
+++ b/supabase/database.types.ts
@@ -787,7 +787,7 @@ export type Database = {
       }
       notes: {
         Row: {
-          content: string | null
+          content: string
           created_at: string
           day: string | null
           id: number
@@ -796,7 +796,7 @@ export type Database = {
           user_id: string
         }
         Insert: {
-          content?: string | null
+          content: string
           created_at?: string
           day?: string | null
           id?: number
@@ -805,7 +805,7 @@ export type Database = {
           user_id: string
         }
         Update: {
-          content?: string | null
+          content?: string
           created_at?: string
           day?: string | null
           id?: number
diff --git a/supabase/migrations/20241228160154_non_nullable_note_content.sql b/supabase/migrations/20241228160154_non_nullable_note_content.sql
new file mode 100644
index 0000000..040ec12
--- /dev/null
+++ b/supabase/migrations/20241228160154_non_nullable_note_content.sql
@@ -0,0 +1 @@
+ALTER TABLE notes ALTER COLUMN content SET NOT NULL;
\ No newline at end of file
diff --git a/tailwind.config.js b/tailwind.config.js
index 3b8130a..e0ad7ae 100644
--- a/tailwind.config.js
+++ b/tailwind.config.js
@@ -9,9 +9,6 @@ export default {
     './node_modules/@nextui-org/theme/dist/**/*.{js,ts,jsx,tsx}',
   ],
   theme: {
-    fontWeight: {
-      normal: 600,
-    },
     extend: {},
   },
   plugins: [