test: enforce error message expectations

Signed-off-by: Dominykas Blyžė <[email protected]>

Author: dominykas

pkg/downloader/chart_downloader_test.go

@@ -16,6 +16,7 @@ limitations under the License.
 package downloader
 
 import (
+	"fmt"
 	"os"
 	"path/filepath"
 	"testing"
@@ -35,7 +36,7 @@ const (
 func TestResolveChartRef(t *testing.T) {
 	tests := []struct {
 		name, ref, expect, version string
-		fail                       bool
+		expectError                string
 	}{
 		{name: "full URL", ref: "http://example.com/foo-1.2.3.tgz", expect: "http://example.com/foo-1.2.3.tgz"},
 		{name: "full URL, HTTPS", ref: "https://example.com/foo-1.2.3.tgz", expect: "https://example.com/foo-1.2.3.tgz"},
@@ -51,10 +52,10 @@ func TestResolveChartRef(t *testing.T) {
 		{name: "reference, testing-relative-trailing-slash repo", ref: "testing-relative-trailing-slash/foo", expect: "http://example.com/helm/charts/foo-1.2.3.tgz"},
 		{name: "reference, testing-relative-trailing-slash repo", ref: "testing-relative-trailing-slash/bar", expect: "http://example.com/helm/bar-1.2.3.tgz"},
 		{name: "encoded URL", ref: "encoded-url/foobar", expect: "http://example.com/with%2Fslash/charts/foobar-4.2.1.tgz"},
-		{name: "full URL, HTTPS, irrelevant version", ref: "https://example.com/foo-1.2.3.tgz", version: "0.1.0", expect: "https://example.com/foo-1.2.3.tgz", fail: true},
-		{name: "full URL, file", ref: "file:///foo-1.2.3.tgz", fail: true},
-		{name: "invalid", ref: "invalid-1.2.3", fail: true},
-		{name: "not found", ref: "nosuchthing/invalid-1.2.3", fail: true},
+		{name: "full URL, HTTPS, irrelevant version", ref: "https://example.com/foo-1.2.3.tgz", version: "0.1.0", expect: "https://example.com/foo-1.2.3.tgz"},
+		{name: "full URL, file", ref: "file:///foo-1.2.3.tgz", expectError: "repo  not found"},
+		{name: "invalid", ref: "invalid-1.2.3", expectError: "non-absolute URLs should be in form of repo_name/path_to_chart, got: invalid-1.2.3"},
+		{name: "not found", ref: "nosuchthing/invalid-1.2.3", expectError: "repo nosuchthing not found"},
 	}
 
 	c := ChartDownloader{
@@ -69,10 +70,13 @@ func TestResolveChartRef(t *testing.T) {
 
 	for _, tt := range tests {
 		u, err := c.ResolveChartVersion(tt.ref, tt.version)
-		if err != nil {
-			if tt.fail {
-				continue
+		if tt.expectError != "" {
+			if tt.expectError != fmt.Sprint(err) {
+				t.Errorf("%s: expected error %q, got %q", tt.name, tt.expectError, err)
 			}
+			continue
+		}
+		if err != nil {
 			t.Errorf("%s: failed with error %q", tt.name, err)
 			continue
 		}