String#split and better ics

Author: dorianmariecom

lib/code/object/ics.rb

@@ -46,7 +46,14 @@ def self.serialize_event(event)
           next unless event.respond_to?(attribute)
 
           serialized = serialize_value(event.public_send(attribute))
-          serialized = serialized.flatten(1) if attribute == :categories && serialized.is_a?(::Array)
+          serialized =
+            if attribute == :categories && serialized.is_a?(::Array)
+              serialized.flatten(1)
+            elsif scalar_event_attribute?(attribute) && serialized.is_a?(::Array)
+              serialized.join(",")
+            else
+              serialized
+            end
           result[attribute] = serialized unless serialized.nil?
         end.merge(
           timestamp: serialize_value(event.dtstamp),
@@ -60,7 +67,9 @@ def self.serialize_value(value)
         case value
         when nil
           nil
-        when ::String, ::Symbol, ::Integer, ::Float, ::BigDecimal, true, false
+        when ::String
+          normalize_string(value)
+        when ::Symbol, ::Integer, ::Float, ::BigDecimal, true, false
           value
         when ::Array
           value.map { |item| serialize_value(item) }
@@ -73,13 +82,24 @@ def self.serialize_value(value)
           if value.respond_to?(:value)
             serialize_value(value.value)
           elsif value.respond_to?(:to_ical)
-            value.to_ical
+            normalize_string(value.to_ical)
           else
-            value.to_s
+            normalize_string(value.to_s)
           end
         end
       end
 
+      def self.scalar_event_attribute?(attribute)
+        !%i[categories attendees geo].include?(attribute)
+      end
+
+      def self.normalize_string(value)
+        value
+          .dup
+          .force_encoding(::Encoding::UTF_8)
+          .encode(::Encoding::UTF_8, invalid: :replace, undef: :replace)
+      end
+
       def self.serialize_date_like(value)
         case value
         when ::Time, ::Date, ::ActiveSupport::TimeWithZone

lib/code/object/string.rb

@@ -74,7 +74,7 @@ def call(**args)
           sig(args)
           code_strip
         when "split"
-          sig(args) { String }
+          sig(args) { String.maybe }
           code_split(code_value)
         else
           super
@@ -162,7 +162,11 @@ def code_strip
       def code_split(value)
         code_value = value.to_code
 
-        List.new(raw.split(code_value.to_s))
+        if code_value.nothing?
+          List.new(raw.split)
+        else
+          List.new(raw.split(code_value.to_s))
+        end
       end
 
       def present?

spec/code/object/ics_spec.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe Code::Object::Ics do
+  it "normalizes binary event strings before json serialization" do
+    source =
+      <<~ICS
+        BEGIN:VCALENDAR
+        VERSION:2.0
+        PRODID:-//code-ruby//EN
+        BEGIN:VEVENT
+        UID:event-1
+        DTSTART:20260327T120000Z
+        DTEND:20260327T133000Z
+        SUMMARY:Joséphine
+        DESCRIPTION:https://luma.com/opv3owre
+        END:VEVENT
+        END:VCALENDAR
+      ICS
+
+    events = described_class.code_parse(Code::Object::String.new(source.b))
+
+    expect { expect(events.to_json).to include("Joséphine") }.not_to output.to_stderr
+  end
+
+  it "serializes comma-separated descriptions as strings" do
+    source =
+      <<~ICS
+        BEGIN:VCALENDAR
+        VERSION:2.0
+        PRODID:-//code-ruby//EN
+        BEGIN:VEVENT
+        UID:event-2
+        DTSTART:20260401T170000Z
+        DTEND:20260401T190000Z
+        SUMMARY:Le Cirque du Donut
+        DESCRIPTION:Bonjour Paris !\\nLe 1er avril, Kate Raworth vous donne rendez-vous, pour une soirée inédite.
+        END:VEVENT
+        END:VCALENDAR
+      ICS
+
+    events = described_class.code_parse(Code::Object::String.new(source))
+    description = events.raw.first.code_get("description").raw
+
+    expect(description).to be_a(String)
+    expect(description).to include("Le 1er avril, Kate Raworth")
+    expect(description).to include("rendez-vous, pour")
+  end
+end