fix: apply feedback to default query key values

Author: rliljest

dev-test/githunt/types.react-query.ts

@@ -507,11 +507,11 @@ export const CurrentUserForProfileDocument = `
 
 export const useCurrentUserForProfileQuery = <TData = CurrentUserForProfileQuery, TError = unknown>(
   dataSource: { endpoint: string; fetchParams?: RequestInit },
-  variables?: CurrentUserForProfileQueryVariables,
+  variables: CurrentUserForProfileQueryVariables = {},
   options?: UseQueryOptions<CurrentUserForProfileQuery, TError, TData>,
 ) => {
   return useQuery<CurrentUserForProfileQuery, TError, TData>(
-    variables === undefined ? ['CurrentUserForProfile', {}] : ['CurrentUserForProfile', variables],
+    ['CurrentUserForProfile', variables],
     fetcher<CurrentUserForProfileQuery, CurrentUserForProfileQueryVariables>(
       dataSource.endpoint,
       dataSource.fetchParams || {},
@@ -527,13 +527,11 @@ export const useInfiniteCurrentUserForProfileQuery = <
   TError = unknown,
 >(
   dataSource: { endpoint: string; fetchParams?: RequestInit },
-  variables?: CurrentUserForProfileQueryVariables,
+  variables: CurrentUserForProfileQueryVariables = {},
   options?: UseInfiniteQueryOptions<CurrentUserForProfileQuery, TError, TData>,
 ) => {
   return useInfiniteQuery<CurrentUserForProfileQuery, TError, TData>(
-    variables === undefined
-      ? ['CurrentUserForProfile.infinite', {}]
-      : ['CurrentUserForProfile.infinite', variables],
+    ['CurrentUserForProfile.infinite', variables],
     metaData =>
       fetcher<CurrentUserForProfileQuery, CurrentUserForProfileQueryVariables>(
         dataSource.endpoint,

packages/plugins/typescript/react-query/src/fetcher.ts

@@ -186,7 +186,7 @@ export abstract class FetcherRenderer {
     hasRequiredVariables,
     operationVariablesTypes,
   }: GenerateConfig): string {
-    return `variables${hasRequiredVariables ? '' : '?'}: ${operationVariablesTypes}`;
+    return `variables: ${operationVariablesTypes}${hasRequiredVariables ? '' : ' = {}'}`;
   }
 
   private generateQueryOptionsSignature(
@@ -203,9 +203,7 @@ export abstract class FetcherRenderer {
 
   private generateInfiniteQueryVariablesSignature(config: GenerateConfig): string {
     if (this.visitor.config.reactQueryVersion <= 4) {
-      return `variables${config.hasRequiredVariables ? '' : '?'}: ${
-        config.operationVariablesTypes
-      }`;
+      return `variables: ${config.operationVariablesTypes}${config.hasRequiredVariables ? '' : ' = {}'}`;
     }
     return `variables: ${config.operationVariablesTypes}`;
   }
@@ -224,9 +222,7 @@ export abstract class FetcherRenderer {
 
   public generateInfiniteQueryKey(config: GenerateConfig, isSuspense: boolean): string {
     const identifier = isSuspense ? 'infiniteSuspense' : 'infinite';
-    if (config.hasRequiredVariables)
-      return `['${config.node.name.value}.${identifier}', variables]`;
-    return `variables === undefined ? ['${config.node.name.value}.${identifier}', {}] : ['${config.node.name.value}.${identifier}', variables]`;
+    return `['${config.node.name.value}.${identifier}', variables]`;
   }
 
   public generateInfiniteQueryOutput(config: GenerateConfig, isSuspense = false) {
@@ -244,8 +240,7 @@ export abstract class FetcherRenderer {
 
   public generateQueryKey(config: GenerateConfig, isSuspense: boolean): string {
     const identifier = isSuspense ? `${config.node.name.value}Suspense` : config.node.name.value;
-    if (config.hasRequiredVariables) return `['${identifier}', variables]`;
-    return `variables === undefined ? ['${identifier}', {}] : ['${identifier}', variables]`;
+    return `['${identifier}', variables]`;
   }
 
   public generateQueryOutput(config: GenerateConfig, isSuspense = false) {