Skip to content

Commit 25ca9a5

Browse files
Rebuild Compose.Material3.Android to pick up CornerBasedShape APIs (#1452) (#1469)
Fixes #1452. When `Xamarin.AndroidX.Compose.Material3Android 1.4.0.3` was packaged in PR #1418, several of its Compose dependencies were still empty facades (real bindings for `Compose.UI.Graphics`, `Compose.UI.Text`, `Compose.UI.Unit`, and parts of `Compose.Foundation` were un-stripped *after* that release in PRs #1438, #1440, #1448, #1454, #1458). In particular, `androidx.compose.foundation.shape.CornerBasedShape` was not resolvable to the binding generator at the time `material3-android` was built, so the generator silently dropped every member that referenced it - including the `Shapes(extraSmall, small, medium, large, extraLarge)` secondary constructor reported in #1452, the `Shapes.{ExtraSmall, Small, Medium, Large, ExtraLarge}` properties, `Shapes.Copy(...)`, and the `*Defaults.GetShape(...)` / `SegmentedButtonDefaults.GetBaseShape(...)` accessors across the package. Concretely, `Xamarin.AndroidX.Compose.Material3.Shapes` in the published 1.4.0.3 binary has zero references to `CornerBasedShape` and only exposes the no-arg `Shapes()` ctor. A fresh rebuild against the current dependency graph produces 27 references to `CornerBasedShape` on that same class, including the 5-arg ctor. No source/transform changes are required - rebuilding against the now- real Compose dependencies is the fix. This bumps the NuGet revision so the rebuilt assembly actually ships, and refreshes `PublicAPI.Unshipped.txt` to record the ~446 newly bound members (auto-regenerated by `Mono.ApiTools.MSBuildTasks` in `_GeneratePublicApiFiles`). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 96217a8 commit 25ca9a5

2 files changed

Lines changed: 447 additions & 1 deletion

File tree

config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,7 @@
408408
"groupId": "androidx.compose.material3",
409409
"artifactId": "material3-android",
410410
"version": "1.4.0",
411-
"nugetVersion": "1.4.0.3",
411+
"nugetVersion": "1.4.0.4",
412412
"nugetId": "Xamarin.AndroidX.Compose.Material3Android"
413413
},
414414
{

0 commit comments

Comments
 (0)