-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Darc and PCS codeflow logic from VmrForwardFlower/VmrBackflower #4351
Comments
There's considerable overhead in terms of debugging difficulty and code readability when introducing new abstract classes. Especially given that VmrForwardFlower and VmrBackFlower are themselves already implementations of the abstract class VmrCodeFlower. |
#4351 Making the VmrCodeflower more slim with stuff that does not belong there
I think most of the things we wanted to do in this issue were covered in an previous PR. Both darc and PCS now have the same entry point in the VmrCodeFlower logic. Think it's safe to close |
Context
There are two ways to use the codeflow: through CLI and through PCS. For forward flow, we have a class called
VmrForwardFlower
that implements most of the flow logic. In the CLI scenario, we directly call into this class and preform what we need to.In the PCS scenario, we have a class on top of this one
PcsVmrForwardFlower
that does some things of it's own, and then calls into theVmrForwardFlower
. This inconsistency makes it a bit hard to read the code.The same goes for the backwards flow
Goal
Make
VmrForwardFlower
andVmrBackwardFlower
abstract, and addDarcForwardFlower/DarcBackwardFlower
to be a class similar to the currently existingPcsVmrFlower
classesThe text was updated successfully, but these errors were encountered: