Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List updated packages in codeflow PRs #4407

Open
premun opened this issue Jan 31, 2025 · 2 comments
Open

List updated packages in codeflow PRs #4407

premun opened this issue Jan 31, 2025 · 2 comments

Comments

@premun
Copy link
Member

premun commented Jan 31, 2025

Context

As part of #3364, we started generating better PR descriptions.
However, they do not yet contain the list of updated packages.
Furthermore, with #4342, we will support adding, updating and removal of packages which the list should reflect correctly.

Goal

List the package changes in codeflow PR descriptions. The listed version diffs should link to the real diff in code just like in the current Maestro PRs.

@dkurepa
Copy link
Member

dkurepa commented Feb 4, 2025

Not sure if it's possible, but we might be able to reuse the same logic for this as the Dependency Flow updates

@adamzip
Copy link
Contributor

adamzip commented Feb 4, 2025

From a discussion with Premek, I believe as part of this task we can also do updates of the PR title.
The title could depend on whether the PR only brings source code changes, or only updates, or both.
Eg:

  1. [main] Update dependencies from dotnet/dotnet
  2. [main] Update code from dotnet/dotnet
  3. [main] Update code & dependencies from dotnet/dotnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

3 participants