Update Keycloak admin variable names in extensions #7124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed constants for Keycloak admin username and password in the `KeycloakResourceBuilderExtensions` class from `KEYCLOAK_ADMIN` and `KEYCLOAK_ADMIN_PASSWORD` to `KC_BOOTSTRAP_ADMIN_USERNAME` and `KC_BOOTSTRAP_ADMIN_PASSWORD`. This change aligns with https://www.keycloak.org/docs/26.0.0/upgrading/#admin-bootstrapping-and-recovery.
dotnet-policy-service
bot
added
the
community-contribution
|
So keycloak is broken today? |
Not yet! But I don't know when it will be, |
|
I think you need to update some tests |
Removed `KEYCLOAK_ADMIN` and `KEYCLOAK_ADMIN_PASSWORD` and replaced them with `KC_BOOTSTRAP_ADMIN_USERNAME` and `KC_BOOTSTRAP_ADMIN_PASSWORD` for improved naming convention while maintaining functionality.
3 tasks
|
@davidfowl, fixed the tests, but I don't understand why it's failing for Linux. |
|
Change seems fine. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This change is good, the redis test is flaky (it shouldn't block this PR). |
davidfowl
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed constants for Keycloak admin username and password in the
KeycloakResourceBuilderExtensionsclass fromKEYCLOAK_ADMINandKEYCLOAK_ADMIN_PASSWORDtoKC_BOOTSTRAP_ADMIN_USERNAMEandKC_BOOTSTRAP_ADMIN_PASSWORD. This change aligns with https://www.keycloak.org/docs/26.0.0/upgrading/#admin-bootstrapping-and-recovery.Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):