Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making native build more fine-grained #59865

Open
wtgodbe opened this issue Jan 14, 2025 · 0 comments
Open

Consider making native build more fine-grained #59865

wtgodbe opened this issue Jan 14, 2025 · 0 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-unified-build

Comments

@wtgodbe
Copy link
Member

wtgodbe commented Jan 14, 2025

Today, we either build all of the native projects, or none of them:

<!-- BuildNative -->
<ItemGroup Condition=" '$(TargetOsName)' == 'win' AND ('$(TargetArchitecture)' == 'x86' OR '$(TargetArchitecture)' == 'x64' OR '$(TargetArchitecture)' == 'arm64') ">
<NativeProjects Include="$(RepoRoot)src\**\*.vcxproj" Exclude="@(ProjectToExclude)" AdditionalProperties="Platform=x64" />
<NativeProjects Include="$(RepoRoot)src\**\*.vcxproj" Exclude="@(ProjectToExclude)" AdditionalProperties="Platform=Win32" />
<NativeProjects Include="$(RepoRoot)src\**\*.vcxproj" Exclude="@(ProjectToExclude)" AdditionalProperties="Platform=arm64" />
</ItemGroup>

We should consider making this more fine-grained - today in the VMR, BuildPass 1 builds all of the native projects, then BuildPass2 builds the Hosting Bundle, which re-builds projects like https://github.com/dotnet/aspnetcore/blob/main/src/Servers/IIS/AspNetCoreModuleV2/IISLib/IISLib.vcxproj. It may be possible to save the ANCM-specific native builds for just pass 2, which would cut a couple minutes of build time in the VMR.

@wtgodbe wtgodbe added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 14, 2025
@wtgodbe wtgodbe self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-unified-build
Projects
None yet
Development

No branches or pull requests

1 participant