Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest image/layer size in Kusto #745

Open
MichaelSimons opened this issue Jan 25, 2021 · 3 comments · May be fixed by #1604
Open

Ingest image/layer size in Kusto #745

MichaelSimons opened this issue Jan 25, 2021 · 3 comments · May be fixed by #1604
Labels
area-infrastructure up-for-grabs

Comments

@MichaelSimons
Copy link
Member

Tracking the image/layer size information is useful for metric tracking purposes. The wire/compressed size is the most useful to track.
@MichaelSimons MichaelSimons mentioned this issue Jan 25, 2021
Closed
@mthalman mthalman moved this to Backlog in .NET Docker Dec 1, 2021
@mthalman mthalman moved this from Backlog to Needs Review in .NET Docker Dec 19, 2022
@mthalman mthalman mentioned this issue Apr 19, 2023
Open
@mthalman
Copy link
Member

[Triage]
This could be useful to track image size changes over time. The image info file could be queried over source history to get this information.

@mthalman mthalman moved this from Needs Review to Backlog in .NET Docker Aug 16, 2023
@lbussell lbussell moved this from Backlog to Current Release in .NET Docker Jan 19, 2024
@lbussell lbussell mentioned this issue Jan 19, 2024
Closed
@lbussell
Copy link
Contributor

lbussell commented May 16, 2024 •
edited
Loading

[Triage] Since dotnet/dotnet-docker#5118 is blocking image size tracking, we should definitely do this. We should prefer to ingest this info into Kusto over using the image-info file (although both wouldn't hurt). This would allow us to get rid of the existing size validation pipeline. This is already mostly implemented, just stubbed out -

docker-tools/src/Microsoft.DotNet.ImageBuilder/src/Commands/IngestKustoImageInfoCommand.cs

Lines 101 to 106 in 8fa3fbf

for (int i = 0; i < platform.Layers.Count; i++)
{
// TODO: Track layer size (currently set to 0) https://github.com/dotnet/docker-tools/issues/745
layerInfo.AppendLine(FormatLayerCsv(
platform.Layers[i], 0, platform.Layers.Count - i, sha, platform, image, repo.Repo, timestamp));
}

@lbussell lbussell changed the title Track image/layer size in image-info Ingest image/layer size in Kusto May 16, 2024
@lbussell lbussell moved this from Current Release to Backlog in .NET Docker Jul 22, 2024
@lbussell lbussell moved this from Backlog to Current Release in .NET Docker Aug 12, 2024
@lbussell lbussell mentioned this issue Aug 12, 2024
Open
@lbussell
Copy link
Contributor

#745 is follow-up work for once this issue is complete.

@lbussell lbussell moved this from Current Release to Post Release in .NET Docker Sep 16, 2024
@lbussell lbussell mentioned this issue Oct 3, 2024
Merged
@lbussell lbussell moved this from Post Release to Current Release in .NET Docker Nov 13, 2024
@lbussell lbussell linked a pull request Feb 21, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-infrastructure up-for-grabs
Projects
.NET Docker
Status: Current Release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add image/layer size to image-info and ingest in Kusto lbussell/docker-tools
3 participants
@MichaelSimons @mthalman @lbussell