Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to dotnet-install script invocation #1644

Closed
lbussell opened this issue Mar 11, 2025 · 0 comments · Fixed by #1645
Closed

Add retries to dotnet-install script invocation #1644

lbussell opened this issue Mar 11, 2025 · 0 comments · Fixed by #1645

Comments

@lbussell
Copy link
Contributor

We need to add retries to the dotnet-install script invocation as a mitigation for https://github.com/dotnet/release/issues/1230

Call site:

$InstallFailed = $false
if ($IsRunningOnUnix) {
& chmod +x $DotnetInstallScriptPath
& $DotnetInstallScriptPath --channel $DotnetChannel --install-dir $InstallPath
$InstallFailed = ($LASTEXITCODE -ne 0)
}
else {
& $DotnetInstallScriptPath -Channel $DotnetChannel -InstallDir $InstallPath
$InstallFailed = (-not $?)
}

@github-project-automation github-project-automation bot moved this to Backlog in .NET Docker Mar 11, 2025
lbussell added a commit that referenced this issue Mar 11, 2025
Fixes #1644

Add retries to dotnet-install script invocation in `Install-DotNetSdk.ps1`.

* Wrap the invocation of the dotnet-install script with the `Invoke-WithRetry.ps1` script.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dotnet/docker-tools/issues/1644?shareId=XXXX-XXXX-XXXX-XXXX).
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Docker Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant