Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: Document Azure.Hosting.ServiceBus obsolete methods #2327

Closed
1 of 3 tasks
sebastienros opened this issue Dec 19, 2024 · 1 comment · Fixed by #2566
Closed
1 of 3 tasks

[Breaking change]: Document Azure.Hosting.ServiceBus obsolete methods #2327

sebastienros opened this issue Dec 19, 2024 · 1 comment · Fixed by #2566
Assignees
Labels
⛓️‍💥 breaking-change Issues or PRs tracking breaking changes. doc-idea Indicates issues that are suggestions for new topics [org][type][category] in-pr okr-freshness OKR: Freshness of content Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. 📦 release-9.1 Used to track doc updates for release 9.1 of .NET Aspire.

Comments

@sebastienros
Copy link
Member

sebastienros commented Dec 19, 2024

Description

AddQueue, AddTopic and AddSubscription are being obsoleted in 9.1 with this PR

Version

Other (please put exact version in description textbox)

Previous behavior

n/a

New behavior

n/a

Type of breaking change

  • Binary incompatible: Existing binaries might encounter a breaking change in behavior, such as failure to load or execute, and if so, require recompilation.
  • Source incompatible: When recompiled using the new SDK or component or to target the new runtime, existing source code might require source changes to compile successfully.
  • Behavioral change: Existing binaries might behave differently at run time.

Reason for change

A better API is provided, the names With reflect that no specific resource is created. Add should be used when it returns a actual resource (not a resource builder).

Recommended action

Update your methods to use the new ones.

Affected APIs

static Aspire.Hosting.AzureServiceBusExtensions.AddQueue(this Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>! builder, string! name) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!
static Aspire.Hosting.AzureServiceBusExtensions.AddQueue(this Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>! builder, string! name, System.Action<Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!, Aspire.Hosting.ResourceModuleConstruct!, Azure.Provisioning.ServiceBus.ServiceBusQueue!>? configureQueue) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!
static Aspire.Hosting.AzureServiceBusExtensions.AddSubscription(this Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>! builder, string! topicName, string! subscriptionName) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!
static Aspire.Hosting.AzureServiceBusExtensions.AddSubscription(this Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>! builder, string! topicName, string! subscriptionName, System.Action<Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!, Aspire.Hosting.ResourceModuleConstruct!, Azure.Provisioning.ServiceBus.ServiceBusSubscription!>? configureSubscription) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!
static Aspire.Hosting.AzureServiceBusExtensions.AddTopic(this Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>! builder, string! name) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!
static Aspire.Hosting.AzureServiceBusExtensions.AddTopic(this Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>! builder, string! name, string![]! subscriptions) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!
static Aspire.Hosting.AzureServiceBusExtensions.AddTopic(this Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>! builder, string! name, System.Action<Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!, Aspire.Hosting.ResourceModuleConstruct!, Azure.Provisioning.ServiceBus.ServiceBusTopic!>? configureTopic) -> Aspire.Hosting.ApplicationModel.IResourceBuilder<Aspire.Hosting.Azure.AzureServiceBusResource!>!


Associated WorkItem - 373404

@sebastienros sebastienros added doc-idea Indicates issues that are suggestions for new topics [org][type][category] Pri1 High priority, do before Pri2 and Pri3 ⛓️‍💥 breaking-change Issues or PRs tracking breaking changes. labels Dec 19, 2024
@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Dec 19, 2024
@IEvangelist IEvangelist added 🗺️ reQUEST Triggers an issue to be imported into Quest. okr-freshness OKR: Freshness of content and removed ⌚ Not Triaged Not triaged labels Feb 13, 2025
@dotnetrepoman dotnetrepoman bot added 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. and removed 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. labels Feb 13, 2025
@dotnetrepoman dotnetrepoman bot added the 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. label Feb 13, 2025
@IEvangelist IEvangelist moved this from 🔖 Ready to 👀 In review in dotnet/docs February 2025 sprint project Feb 13, 2025
@dotnetrepoman dotnetrepoman bot removed the 🗺️ mapQUEST Only used as a way to mark an issue as updated. RepoMan should instantly remove it. label Feb 13, 2025
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Feb 14, 2025
@IEvangelist IEvangelist added the 📦 release-9.1 Used to track doc updates for release 9.1 of .NET Aspire. label Feb 18, 2025
@eerhardt
Copy link
Member

@IEvangelist - I missed logging this. We removed the With* APIs at the end of 9.1. See

The easiest way of seeing the final results is to look at these 3 files:

This isn't just for ServiceBus, but also EventHubs and CosmosDB as well.

ServiceBus

  • AddQueue => AddServiceBusQueue
  • AddTopic => AddServiceBusTopic
  • AddSubscription => AddServiceBusTopic("").AddServiceBusSubscription("")

Event Hubs

  • AddEventHub => AddHub

CosmosDB

  • AddDatabase => AddCosmosDatabase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛓️‍💥 breaking-change Issues or PRs tracking breaking changes. doc-idea Indicates issues that are suggestions for new topics [org][type][category] in-pr okr-freshness OKR: Freshness of content Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest. 📦 release-9.1 Used to track doc updates for release 9.1 of .NET Aspire.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants