Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.Data.Sqlite.Core TFMs #35599

Open
AndriySvyryd opened this issue Feb 7, 2025 · 3 comments
Open

Update Microsoft.Data.Sqlite.Core TFMs #35599

AndriySvyryd opened this issue Feb 7, 2025 · 3 comments

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Feb 7, 2025

For .NET 11 we need to consider whether Microsoft.Data.Sqlite.Core should continue to support .NET Framework. And we should drop netstandard2.0 to avoid giving the impression that older TFMs like net8.0 are still supported. So, the final set would be one of:

  • net10.0
  • net10.0;net472
  • net11.0;net10.0
  • net11.0;net10.0;net472
@roji
Copy link
Member

roji commented Feb 7, 2025

@AndriySvyryd as per the discussion in https://github.com/dotnet/efcore/pull/35589/files#r1944379793, we also have the option of simply keeping netstandard2.0 and multitargeting to the minimum supported TFM (currently net8.0, for .NET 11 it will be net10.0).

@AndriySvyryd
Copy link
Member Author

AndriySvyryd commented Feb 8, 2025

Keeping netstandard2.0 will always result in the situation where an older TFM appears to be supported but suddenly loses DateOnly and TimeOnly support.

@roji
Copy link
Member

roji commented Feb 8, 2025

Keeping netstandard2.0 will always result in the situation where an older TFM appears to be supported but suddenly loses DateOnly and TimeOnly support.

That's true - I'm just arguing that we shouldn't have that happened for supported TFMs (e.g. net8.0 currently). What happens to unsupported TFMs seems much less important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants