Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHandlerTagHelperDescriptorProvider throws InvalidOprationException in dotnet-watch unit test environment #10818

Open
tmat opened this issue Aug 31, 2024 · 3 comments
Labels
area-compiler Umbrella for all compiler issues

Comments

@tmat
Copy link
Member

tmat commented Aug 31, 2024

When EventHandlerAttribute is not decoded as expected the source generator throws an exception.

See https://github.com/dotnet/razor/blob/main/src/Compiler/Microsoft.CodeAnalysis.Razor.Compiler/src/CSharp/EventHandlerTagHelperDescriptorProvider.cs#L60

The exception message does not include details about which type caused the failure making it hard to find out what's wrong.

The ask is to:

  1. Update Razor source generator to include information in the exception message that pinpoints the problematic type.
  2. Insert updated Razor to .NET SDK repo and enable commented out code in dotnet-watch test ApplyDeltaTests.BlazorWasm.
  3. Run the test, determine the root cause of the failure and address it.
@tmat
Copy link
Member Author

tmat commented Aug 31, 2024

@DustinCampbell FYI

@davidwengier davidwengier added the area-compiler Umbrella for all compiler issues label Aug 31, 2024
@jjonescz
Copy link
Member

jjonescz commented Sep 4, 2024

Fixed by #10828?

@tmat
Copy link
Member Author

tmat commented Sep 4, 2024

Not until we can enable the test in dotnet-watch and validate.

@chsienki chsienki added this to the 17.12 Planning milestone Sep 5, 2024
@chsienki chsienki removed the untriaged label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Development

No branches or pull requests

4 participants