Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FUSE] Section names in cshtml files are not mapped #10857

Open
davidwengier opened this issue Sep 9, 2024 · 2 comments
Open

[FUSE] Section names in cshtml files are not mapped #10857

davidwengier opened this issue Sep 9, 2024 · 2 comments
Labels
area-compiler Umbrella for all compiler issues New Feature: Fuse

Comments

@davidwengier
Copy link
Contributor

davidwengier commented Sep 9, 2024

I'm not actually sure if this is a bug, or just a difference, but right now in design time @section names are mapped to an object in the generated C#, so get classified by Roslyn, and would have to be valid C# identifiers etc. In runtime the section names are just an opaque string, and are not mapped.

This might not really help in tooling at all, but its at least a cause of a failing test so we should sort something out.

(Saw this in the cohost_use_generator branch, so it might not be FUSE, but I'm pretty sure)

davidwengier added a commit that referenced this issue Sep 10, 2024
Skipped folding range test tracked by #10859
Skipped rename test tracked by #10856
Updated semantic tokens test tracked by #10857
Update folding range tests tracked by #10860
Update spell checking test tracked by #10863
Skipped formatting tests tracked by #10864
Skipped auto insert tests tracked by #10865
@phil-allen-msft phil-allen-msft added New Feature: Fuse area-compiler Umbrella for all compiler issues labels Sep 12, 2024
@jaredpar
Copy link
Member

jaredpar commented Oct 8, 2024

@chsienki is this FUSE related?

@chsienki
Copy link
Contributor

chsienki commented Oct 8, 2024

@jaredpar Yes, but after discussion I'm going to close it as by-design. It's a case where something has always been legal in runtime (and thus the command line compiler) but would fail at design time and squiggle in the IDE. Under fuse we no longer incorrectly squiggle.

Leaving it open right now to track removing the failing test that checks for the squiggle.

@chsienki chsienki added this to the 17.13 Planning milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues New Feature: Fuse
Projects
None yet
Development

No branches or pull requests

4 participants