Convert Zero/One/ImaginaryOne/NaN/Infinity from static readonly fields to static properties in Complex<T>; remove redundant INumberBase.One/Zero explicit impls

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/4daa6a5a-87a9-46b6-b055-56ce91e228a2

Co-authored-by: tannergooding <10487869+tannergooding@users.noreply.github.com>

Author: Copilot

src/libraries/System.Runtime.Numerics/ref/System.Runtime.Numerics.cs

@@ -403,19 +403,17 @@ namespace System.Numerics
         where T : System.Numerics.IFloatingPointIeee754<T>, System.Numerics.IMinMaxValue<T>
     {
         private readonly int _dummyPrimitive;
-        public static readonly System.Numerics.Complex<T> ImaginaryOne;
-        public static readonly System.Numerics.Complex<T> Infinity;
-        public static readonly System.Numerics.Complex<T> NaN;
-        public static readonly System.Numerics.Complex<T> One;
-        public static readonly System.Numerics.Complex<T> Zero;
+        public static System.Numerics.Complex<T> ImaginaryOne { get { throw null; } }
+        public static System.Numerics.Complex<T> Infinity { get { throw null; } }
+        public static System.Numerics.Complex<T> NaN { get { throw null; } }
+        public static System.Numerics.Complex<T> One { get { throw null; } }
+        public static System.Numerics.Complex<T> Zero { get { throw null; } }
         public Complex(T real, T imaginary) { throw null; }
         public T Imaginary { get { throw null; } }
         public T Real { get { throw null; } }
         static System.Numerics.Complex<T> System.Numerics.IAdditiveIdentity<System.Numerics.Complex<T>,System.Numerics.Complex<T>>.AdditiveIdentity { get { throw null; } }
         static System.Numerics.Complex<T> System.Numerics.IMultiplicativeIdentity<System.Numerics.Complex<T>,System.Numerics.Complex<T>>.MultiplicativeIdentity { get { throw null; } }
-        static System.Numerics.Complex<T> System.Numerics.INumberBase<System.Numerics.Complex<T>>.One { get { throw null; } }
         static int System.Numerics.INumberBase<System.Numerics.Complex<T>>.Radix { get { throw null; } }
-        static System.Numerics.Complex<T> System.Numerics.INumberBase<System.Numerics.Complex<T>>.Zero { get { throw null; } }
         static System.Numerics.Complex<T> System.Numerics.ISignedNumber<System.Numerics.Complex<T>>.NegativeOne { get { throw null; } }
         public static T Abs(System.Numerics.Complex<T> value) { throw null; }
         public static System.Numerics.Complex<T> Acos(System.Numerics.Complex<T> value) { throw null; }

src/libraries/System.Runtime.Numerics/src/System/Numerics/Complex.Generic.cs

@@ -23,11 +23,11 @@ public readonly struct Complex<T>
           IUtf8SpanFormattable
         where T : IFloatingPointIeee754<T>, IMinMaxValue<T>
     {
-        public static readonly Complex<T> Zero = new(T.Zero, T.Zero);
-        public static readonly Complex<T> One = new(T.One, T.Zero);
-        public static readonly Complex<T> ImaginaryOne = new(T.Zero, T.One);
-        public static readonly Complex<T> NaN = new(T.NaN, T.NaN);
-        public static readonly Complex<T> Infinity = new(T.PositiveInfinity, T.PositiveInfinity);
+        public static Complex<T> Zero => new(T.Zero, T.Zero);
+        public static Complex<T> One => new(T.One, T.Zero);
+        public static Complex<T> ImaginaryOne => new(T.Zero, T.One);
+        public static Complex<T> NaN => new(T.NaN, T.NaN);
+        public static Complex<T> Infinity => new(T.PositiveInfinity, T.PositiveInfinity);
 
         // 1 / Log(10)
         private static readonly T s_inverseOfLog10 = T.One / T.Log(T.CreateChecked(10));
@@ -715,7 +715,7 @@ public static implicit operator Complex<T>(T value)
         //
 
         /// <inheritdoc cref="IAdditiveIdentity{TSelf, TResult}.AdditiveIdentity" />
-        static Complex<T> IAdditiveIdentity<Complex<T>, Complex<T>>.AdditiveIdentity => new(T.Zero, T.Zero);
+        static Complex<T> IAdditiveIdentity<Complex<T>, Complex<T>>.AdditiveIdentity => Zero;
 
         //
         // IDecrementOperators
@@ -736,21 +736,15 @@ public static implicit operator Complex<T>(T value)
         //
 
         /// <inheritdoc cref="IMultiplicativeIdentity{TSelf, TResult}.MultiplicativeIdentity" />
-        static Complex<T> IMultiplicativeIdentity<Complex<T>, Complex<T>>.MultiplicativeIdentity => new(T.One, T.Zero);
+        static Complex<T> IMultiplicativeIdentity<Complex<T>, Complex<T>>.MultiplicativeIdentity => One;
 
         //
         // INumberBase
         //
 
-        /// <inheritdoc cref="INumberBase{TSelf}.One" />
-        static Complex<T> INumberBase<Complex<T>>.One => new(T.One, T.Zero);
-
         /// <inheritdoc cref="INumberBase{TSelf}.Radix" />
         static int INumberBase<Complex<T>>.Radix => T.Radix;
 
-        /// <inheritdoc cref="INumberBase{TSelf}.Zero" />
-        static Complex<T> INumberBase<Complex<T>>.Zero => new(T.Zero, T.Zero);
-
         /// <inheritdoc cref="INumberBase{TSelf}.Abs(TSelf)" />
         static Complex<T> INumberBase<Complex<T>>.Abs(Complex<T> value) => Abs(value);