Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli native code is compiled with LTCG #111566

Open
MichalStrehovsky opened this issue Jan 18, 2025 · 3 comments
Open

Brotli native code is compiled with LTCG #111566

MichalStrehovsky opened this issue Jan 18, 2025 · 3 comments
Assignees
Labels
area-NativeAOT-coreclr untriaged New issue has not been triaged by the area owner

Comments

@MichalStrehovsky
Copy link
Member

And this is going to break everyone who doesn't use exactly the same version of VC++ as we used on the build machine.

Reported at aspnet/Benchmarks#2047. We should also check zlib.

  brotlienc.lib(encode.c.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
EXEC : fatal error C1900: Il mismatch between 'P1' version '20240319' and 'P2' version '20220715' [C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-6848\ooktqbfk.xuf\src\Benchmarks\Benchmarks.csproj]
LINK : fatal error LNK1257: code generation failed [C:\Users\Administrator\AppData\Local\Temp\benchmarks-agent\benchmarks-server-6848\ooktqbfk.xuf\src\Benchmarks\Benchmarks.csproj]
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jan 18, 2025
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jan 18, 2025

cc @jkoritzinsky Regression introduced by #109707 ?

@jkoritzinsky
Copy link
Member

Yes this was introduced by #109707.

@jkoritzinsky jkoritzinsky self-assigned this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NativeAOT-coreclr untriaged New issue has not been triaged by the area owner
Projects
Status: No status
Development

No branches or pull requests

3 participants