From 106bbde95e5420713b25a57f9dd3067745f095f2 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Wed, 18 Sep 2024 15:37:23 -0500 Subject: [PATCH 1/3] Treat -rtm versions as stable workload sdk bands --- eng/Versions.props | 4 ++-- .../Sdk/WorkloadTesting.Core.targets | 2 +- src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index ee814c4a4280f..26afc0058b7fc 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -16,8 +16,8 @@ false release - -$(PreReleaseVersionLabel) - -$(PreReleaseVersionLabel).$(PreReleaseVersionIteration) + -$(PreReleaseVersionLabel) + -$(PreReleaseVersionLabel).$(PreReleaseVersionIteration) $(SdkBandVersion)$(WorkloadVersionSuffix) diff --git a/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets b/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets index d853cb881eb84..93fdb93172af4 100755 --- a/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets +++ b/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets @@ -110,7 +110,7 @@ - $(SdkBandVersion)$([System.Text.RegularExpressions.Regex]::Match($(_DotNetVersionOutput), `-[A-z]*[\.]*\d*`)) + $(SdkBandVersion)$([System.Text.RegularExpressions.Regex]::Match($(_DotNetVersionOutput), `-(?!rtm)[A-z]*[\.]*\d*`)) $(SdkBandVersionForWorkload_ComputedFromInstaller) $(VersionBandForSdkManifestsDir) diff --git a/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs b/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs index d5b163168d8f7..501c58a33fc91 100644 --- a/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs +++ b/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs @@ -56,7 +56,7 @@ public partial class InstallWorkloadFromArtifacts : PatchNuGetConfig ReadCommentHandling = JsonCommentHandling.Skip }; - [GeneratedRegex(@"^\d+\.\d+\.\d+(-[A-z]*\.*\d*)?")] + [GeneratedRegex(@"^\d+\.\d+\.\d+(-(?!rtm)[A-z]*\.*\d*)?")] private static partial Regex bandVersionRegex(); public override bool Execute() From a2cb890f1f97369cb9a861cb8eb34a6795f7edcb Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Wed, 18 Sep 2024 16:14:31 -0500 Subject: [PATCH 2/3] Handle rtm specially here too --- src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs b/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs index 501c58a33fc91..0427f1ba436dd 100644 --- a/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs +++ b/src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs @@ -301,7 +301,8 @@ private bool InstallWorkloadManifest(ITaskItem workloadId, string name, string v if (!string.IsNullOrEmpty(bandPreleaseVersion) && packagePreleaseVersion != bandPreleaseVersion && packagePreleaseVersion != "-dev" && - packagePreleaseVersion != "-ci") + packagePreleaseVersion != "-ci" && + packagePreleaseVersion != "-rtm") { bandVersion = bandVersion.Replace (bandPreleaseVersion, packagePreleaseVersion); } From 819ccbee7e158ad3b36ec1239539f5096df1e603 Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Fri, 20 Sep 2024 12:15:30 -0500 Subject: [PATCH 3/3] Update to the latest net 9 emsdk --- eng/Version.Details.xml | 8 ++++---- eng/Versions.props | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index dac31c111a971..b0bb52b3c87ad 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -64,14 +64,14 @@ 526b22d829bc9b420dff6ef70877a67053b66e0f - + https://github.com/dotnet/emsdk - c3d83d0ea894e5ee537bfc591fd48e06af8d9166 + 8e660ff41e91879977e3a9d837e068bd72234c26 - + https://github.com/dotnet/emsdk - c3d83d0ea894e5ee537bfc591fd48e06af8d9166 + 8e660ff41e91879977e3a9d837e068bd72234c26 diff --git a/eng/Versions.props b/eng/Versions.props index 4a727a595d168..f24d3a0bc3f50 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -239,7 +239,7 @@ Note: when the name is updated, make sure to update dependency name in eng/pipelines/common/xplat-setup.yml like - DarcDependenciesChanged.Microsoft_NET_Workload_Emscripten_Current_Manifest-9_0_100_Transport --> - 9.0.0-rc.2.24464.3 + 9.0.0-rtm.24469.1 $(MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion) 1.1.87-gba258badda