Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #112163 #112215

Closed
wants to merge 2 commits into from
Closed

fix #112163 #112215

wants to merge 2 commits into from

Conversation

Ruihan-Yin
Copy link
Contributor

More details in #112163 (comment)

I'm not so sure if simply isolating the case for vmovss will be a proper fix, but I will run through the CI first to check if there is any other problem.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 5, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 5, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@saucecontrol
Copy link
Member

Sorry, I didn't see you had put this up. I've created #112217 which also covers double->double (movsd would also get the bad encoding as is)

@Ruihan-Yin
Copy link
Contributor Author

Ruihan-Yin commented Feb 6, 2025 •
edited
Loading

Sorry, I didn't see you had put this up. I've created #112217 which also covers double->double (movsd would also get the bad encoding as is)

That's completely fine, happy to see this bug is being addressed so quickly, I'm fine with closing this PR and proceed on your side if needed, and please let me know if anything I can help with.

@saucecontrol
Copy link
Member

happy to see this bug is being addressed so quickly

Same. I appreciate your help root-causing it 😄

@Ruihan-Yin
Copy link
Contributor Author

Closing as #112217 is covering this bug and providing a better solution.

@Ruihan-Yin Ruihan-Yin closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruihan-Yin @saucecontrol