Skip to content

dotnet-watch tests failing #40006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsplaisted opened this issue Apr 4, 2024 · 12 comments
Open

dotnet-watch tests failing #40006

dsplaisted opened this issue Apr 4, 2024 · 12 comments

Comments

@dsplaisted
Copy link
Member

dsplaisted commented Apr 4, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=629827
Build error leg or test failing: dotnet-watch.Tests.dll.1.WorkItemExecution
Pull request: #39888

Error Message

##[error].packages/microsoft.dotnet.helix.sdk/8.0.0-beta.24177.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item dotnet-watch.Tests.dll.1 in job 82728a56-9430-4356-ab82-1c21670792a7 has failed

{
  "ErrorMessage": "",
  "ErrorPattern": "Work item dotnet-watch\\.Tests\\.dll\\.1 in job [a-z0-9\\-]+ has failed",
  "BuildRetry": true,
  "ExcludeConsoleLog": true
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=629827
Error message validated: [Work item dotnet-watch\.Tests\.dll\.1 in job [a-z0-9\-]+ has failed]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2024 9:51:10 AM UTC

Report

Build Definition Step Name Console log Pull Request
1033821 dotnet/sdk Run TestBuild Tests Log #48697
1033729 dotnet/sdk 🟣 Run TestBuild Tests Log #48813
2698630 dotnet-sdk Run TestBuild Tests Log #49424
1029908 dotnet/sdk Run TestBuild Tests Log #48773
2697900 dotnet-sdk Run FullFramework Tests Log #49424
1027611 dotnet/sdk Run FullFramework Tests Log #48736
1027246 dotnet/sdk Run TestBuild Tests Log #48735
1027155 dotnet/sdk Run TestBuild Tests Log #48731
1027076 dotnet/sdk 🟣 Run TestBuild Tests Log #48690
2694051 dotnet-sdk Run FullFramework Tests Log #49424
1023289 dotnet/sdk Run FullFramework Tests Log #48611
1023178 dotnet/sdk 🟣 Run TestBuild Tests Log #48587
1021108 dotnet/sdk 🟣 Run FullFramework Tests Log #48028
1020922 dotnet/sdk Run FullFramework Tests Log #48589
1020237 dotnet/sdk 🟣 Run FullFramework Tests Log #48436
1019981 dotnet/sdk Run TestBuild Tests Log #48556
2689266 dotnet-sdk Run TestBuild Tests Log #49269
2689020 dotnet-sdk Run TestBuild Tests Log #49252
1018194 dotnet/sdk 🟣 Run TestBuild Tests Log #48477
1017988 dotnet/sdk Run TestBuild Tests Log #48494
2688317 dotnet-sdk Run FullFramework Tests Log #49223
2688152 dotnet-sdk Run TestBuild Tests Log #49128
1017353 dotnet/sdk Run TestBuild Tests Log #48486
1016809 dotnet/sdk Run FullFramework Tests Log #48472
1016293 dotnet/sdk Run TestBuild Tests Log #48447
2686950 dotnet-sdk Run TestBuild Tests Log #49128
1015325 dotnet/sdk Run FullFramework Tests Log #48430
1015239 dotnet/sdk Run TestBuild Tests Log #48393
1015036 dotnet/sdk Run TestBuild Tests Log #48425
2685339 dotnet-sdk Run FullFramework Tests Log #48918
2685332 dotnet-sdk Run TestBuild Tests Log #49129
1014045 dotnet/sdk Run FullFramework Tests Log #48405
1013477 dotnet/sdk Run TestBuild Tests Log #48274
1012858 dotnet/sdk Run TestBuild Tests Log #48365
1012929 dotnet/sdk Run TestBuild Tests Log #48266
1012824 dotnet/sdk Run TestBuild Tests Log #48363
1012580 dotnet/sdk 🟣 Run TestBuild Tests Log #48353
1012515 dotnet/sdk 🟣 Run TestBuild Tests Log #48353
1012496 dotnet/sdk Run TestBuild Tests Log #48274
1012414 dotnet/sdk Run TestBuild Tests Log #48356
1012268 dotnet/sdk 🟣 Run TestBuild Tests Log #48353
1011910 dotnet/sdk Run TestBuild Tests Log #48291
1011706 dotnet/sdk Run TestBuild Tests Log #48341
2683475 dotnet-sdk Run TestBuild Tests Log #48610
1010510 dotnet/sdk Run TestBuild Tests Log #48298
1010475 dotnet/sdk Run TestBuild Tests Log #48305
1010372 dotnet/sdk Run TestBuild Tests Log #48298
1010369 dotnet/sdk Run TestBuild Tests Log #48297
2682841 dotnet-sdk Run TestBuild Tests Log #48610
1010094 dotnet/sdk 🟣 Run TestBuild Tests Log #48277
1009755 dotnet/sdk Run FullFramework Tests Log #48005
1009247 dotnet/sdk 🟣 Run TestBuild Tests Log #48246
1009236 dotnet/sdk 🟣 Run TestBuild Tests Log #48087
1008785 dotnet/sdk Run FullFramework Tests Log #48005
2681751 dotnet-sdk Run FullFramework Tests Log #48610
2681707 dotnet-sdk Run FullFramework Tests Log #48611
1008115 dotnet/sdk Run TestBuild Tests Log #45520
1007537 dotnet/sdk Run TestBuild Tests Log #48149
1007531 dotnet/sdk Run TestBuild Tests Log #48151
1007356 dotnet/sdk Run TestBuild Tests Log #48185
1006402 dotnet/sdk Run TestBuild Tests Log #48196

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
2 5 61
@marcpopMSFT
Copy link
Member

@tmat
Copy link
Member

tmat commented Jun 26, 2024

No luck yet. This might help: https://github.com/dotnet/sdk/blob/d45e40d665e647804de03d2b4eec2aae9c488cb5/test/dotnet-watch.Tests/xunit.runner.json

It will print out test info every 20 seconds a test is running.

@marcpopMSFT
Copy link
Member

@tmat another failure this morning shows a bunch of build processes for watch apps still running... https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-41958-merge-84357342ee154a5088/dotnet-watch.Tests.dll.2/1/console.3dddc463.log?helixlogtype=result

@tmat
Copy link
Member

tmat commented Jul 3, 2024

Looks like that's in 8.0 branch. Porting test diagnostics from 9: #41963

@Forgind
Copy link
Member

Forgind commented Aug 26, 2024

This has been making one of my PRs fail today, so I looked into it a bit. Based on when this issue was created and which tests are failing, I suspect this PR:
#39618

I asked jasonmalinowski whether the MSBuildWorkspace is supposed to support F# because I'd found a code snippet that suggested that it shouldn't, and he said it doesn't and never did. Did that PR make us use MSBuildWorkspace in a different way than we had before?

@Forgind
Copy link
Member

Forgind commented Aug 26, 2024

The changes to HotReloadDotNetWatcher look most suspicious to me. It looks like a substantial change to how we call MSBuild.

@Forgind
Copy link
Member

Forgind commented Jan 18, 2025

Ping @tmat
This is still a serious pain point, currently preventing MSBuild from merging their code flow to 9.0.2xx. I already clicked rerun twice. I pointed to a PR that I think is likely to blame.

@tmat
Copy link
Member

tmat commented Jan 19, 2025

Fixes targeting 9.0.3xx: #45999, #46141

@nagilson
Copy link
Member

@tmat Thank you for making some PRs to try to remedy this -- we are still seeing this in 9.0.2xx, 9.0.1xx, and main, 10 preview 2. Do your changes need to be ported?

@tmat
Copy link
Member

tmat commented Feb 20, 2025

They don't flow automatically to main?

Re 9.0.2xx, 9.0.1xx - these are product changes. Do they meet the servicing bar?

@nagilson
Copy link
Member

nagilson commented Feb 20, 2025

They should flow to main, but either something went wrong and it didn't for those PRs, or the fix did not work, since it is still showing up in .net 10 preview 2: #46983

I dont think they would meet the bar that, so good point. 9.0.3xx though, they probably do.

@tmat
Copy link
Member

tmat commented Feb 21, 2025

Might be something else causing failure in 10 P2. Do you have a link to the failed run? The PR is merged.

@dotnet-policy-service dotnet-policy-service bot removed the untriaged Request triage from a team member label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants