Skip to content

Incremental build is broken for external packages with patches #1520

Description

@ViktorHofer

https://github.com/dotnet/source-build-reference-packages/blob/a2143ed684ba97f3cf65964fdef8d5fae0ebcda6/src/externalPackages/projects/Directory.Build.targets#L15-L47

  1. The PrepareInnerClone target always runs but skips unchanged files.
  2. The ApplyPatches target which runs after PrepareInnerClone only runs once successfully as it then creates an output marker file.

If something fails in the SBRP repo and I run the build again, the PrepareInnerClone target runs again and overwrites the patched files but the ApplyPatches target doesn't run anymore.

Metadata

Metadata

Assignees

Labels

untriagedNeeds to be triaged

Type

No type

Fields

No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions