Skip to content

Support rollForward global.json version matching pattern in findPath API #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nagilson opened this issue Feb 14, 2025 · 0 comments · Fixed by #2139
Closed

Support rollForward global.json version matching pattern in findPath API #2138

nagilson opened this issue Feb 14, 2025 · 0 comments · Fixed by #2139

Comments

@nagilson
Copy link
Member

Is your feature request related to a problem? Please describe.

The rollForward value can be disabled, major, minor, latestPatch etc. Due to this issue with aspire: dotnet/aspire#6701, we have been asked to findPaths only with runtime 9.0.2 or higher. Our >= requirement only is sufficient for allowing any 9.0 patch >= that patch, so 10 would be allowed.

A clear and concise description of what you want to happen. Include any alternative solutions you've considered.

^

Describe the solution you'd like

Add a different option that you can provide in the find path context.

Additional context

No response

@nagilson nagilson changed the title Support rollForward global.json in findPath API Support rollForward global.json version matching pattern in findPath API Feb 14, 2025
nagilson added a commit to nagilson/vscode-dotnet-runtime that referenced this issue Feb 14, 2025
…json

Resolves dotnet#2138

Need to add some tests, this logic is very WIP
As requested by @lifengl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant