Remove configuration api. (#5358)

Author: imcarolwang

src/System.ServiceModel.Http/src/System/ServiceModel/NetHttpBinding.cs

@@ -32,12 +32,6 @@ public NetHttpBinding(BasicHttpSecurityMode securityMode, bool reliableSessionEn
             ReliableSession.Enabled = reliableSessionEnabled;
         }
 
-        public NetHttpBinding(string configurationName)
-            : base()
-        {
-            Initialize();
-        }
-
         private NetHttpBinding(BasicHttpSecurity security)
             : base()
         {

src/System.ServiceModel.NetTcp/src/System/ServiceModel/NetTcpBinding.cs

@@ -32,15 +32,6 @@ public NetTcpBinding(SecurityMode securityMode, bool reliableSessionEnabled) : t
             ReliableSession.Enabled = reliableSessionEnabled;
         }
 
-        public NetTcpBinding(string configurationName)
-            : this()
-        {
-            if (!string.IsNullOrEmpty(configurationName))
-            {
-                throw new PlatformNotSupportedException();
-            }
-        }
-
         [DefaultValue(ConnectionOrientedTransportDefaults.TransferMode)]
         public TransferMode TransferMode
         {

src/System.ServiceModel.Primitives/ref/System.ServiceModel.Duplex.cs

@@ -36,10 +36,6 @@ public DuplexChannelFactory(Type callbackInstanceType, System.ServiceModel.Descr
         public DuplexChannelFactory(System.ServiceModel.InstanceContext callbackInstance, System.ServiceModel.Channels.Binding binding) : base(default(System.Type)) { }
         public DuplexChannelFactory(System.ServiceModel.InstanceContext callbackInstance, System.ServiceModel.Channels.Binding binding, System.ServiceModel.EndpointAddress remoteAddress) : base(default(System.Type)) { }
         public DuplexChannelFactory(System.ServiceModel.InstanceContext callbackInstance, System.ServiceModel.Channels.Binding binding, string remoteAddress) : base(default(System.Type)) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public DuplexChannelFactory(System.ServiceModel.InstanceContext callbackInstance, string endpointConfigurationName) : base(default(System.Type)) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public DuplexChannelFactory(System.ServiceModel.InstanceContext callbackInstance, string endpointConfigurationName, System.ServiceModel.EndpointAddress remoteAddress) : base(default(System.Type)) { }
         public override TChannel CreateChannel(System.ServiceModel.EndpointAddress address, System.Uri via) { return default(TChannel); }
         public TChannel CreateChannel(System.ServiceModel.InstanceContext callbackInstance) { return default(TChannel); }
         public TChannel CreateChannel(System.ServiceModel.InstanceContext callbackInstance, System.ServiceModel.EndpointAddress address) { return default(TChannel); }
@@ -49,11 +45,5 @@ public abstract partial class DuplexClientBase<TChannel> : System.ServiceModel.C
     {
         protected DuplexClientBase(System.ServiceModel.InstanceContext callbackInstance) { }
         protected DuplexClientBase(System.ServiceModel.InstanceContext callbackInstance, System.ServiceModel.Channels.Binding binding, System.ServiceModel.EndpointAddress remoteAddress) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        protected DuplexClientBase(System.ServiceModel.InstanceContext callbackInstance, string endpointConfigurationName) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        protected DuplexClientBase(System.ServiceModel.InstanceContext callbackInstance, string endpointConfigurationName, System.ServiceModel.EndpointAddress remoteAddress) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        protected DuplexClientBase(System.ServiceModel.InstanceContext callbackInstance, string endpointConfigurationName, string remoteAddress) { }
     }
 }

src/System.ServiceModel.Primitives/ref/System.ServiceModel.Primitives.cs

@@ -236,16 +236,12 @@ protected ChannelFactory() { }
         protected override System.TimeSpan DefaultCloseTimeout { get { return default; } }
         protected override System.TimeSpan DefaultOpenTimeout { get { return default; } }
         public System.ServiceModel.Description.ServiceEndpoint Endpoint { get { return default; } }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        protected virtual void ApplyConfiguration(string configurationName) { }
         protected abstract System.ServiceModel.Description.ServiceEndpoint CreateDescription();
         protected virtual System.ServiceModel.Channels.IChannelFactory CreateFactory() { return default; }
         protected internal void EnsureOpened() { }
         public T GetProperty<T>() where T : class { return default; }
         protected void InitializeEndpoint(System.ServiceModel.Channels.Binding binding, System.ServiceModel.EndpointAddress address) { }
         protected void InitializeEndpoint(System.ServiceModel.Description.ServiceEndpoint endpoint) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        protected void InitializeEndpoint(string configurationName, System.ServiceModel.EndpointAddress address) { }
         protected override void OnAbort() { }
         protected override System.IAsyncResult OnBeginClose(System.TimeSpan timeout, System.AsyncCallback callback, object state) { return default; }
         protected override System.IAsyncResult OnBeginOpen(System.TimeSpan timeout, System.AsyncCallback callback, object state) { return default; }
@@ -262,10 +258,6 @@ public partial class ChannelFactory<TChannel> : System.ServiceModel.ChannelFacto
         public ChannelFactory(System.ServiceModel.Channels.Binding binding) { }
         public ChannelFactory(System.ServiceModel.Channels.Binding binding, System.ServiceModel.EndpointAddress remoteAddress) { }
         public ChannelFactory(System.ServiceModel.Description.ServiceEndpoint endpoint) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public ChannelFactory(string endpointConfigurationName) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public ChannelFactory(string endpointConfigurationName, System.ServiceModel.EndpointAddress remoteAddress) { }
         protected ChannelFactory(System.Type channelType) { }
         public TChannel CreateChannel() { return default; }
         public TChannel CreateChannel(System.ServiceModel.EndpointAddress address) { return default; }
@@ -284,12 +276,6 @@ public abstract partial class ClientBase<TChannel> : System.IDisposable, System.
         protected ClientBase() { }
         protected ClientBase(System.ServiceModel.Channels.Binding binding, System.ServiceModel.EndpointAddress remoteAddress) { }
         protected ClientBase(System.ServiceModel.Description.ServiceEndpoint endpoint) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        protected ClientBase(string endpointConfigurationName) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        protected ClientBase(string endpointConfigurationName, System.ServiceModel.EndpointAddress remoteAddress) { }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        protected ClientBase(string endpointConfigurationName, string remoteAddress) { }
         protected TChannel Channel { get { return default; } }
         public static CacheSetting CacheSetting { get { return default; } set { } }
         public System.ServiceModel.ChannelFactory<TChannel> ChannelFactory { get { return default; } }

src/System.ServiceModel.Primitives/src/System/ServiceModel/ChannelFactory.cs

@@ -14,7 +14,6 @@ namespace System.ServiceModel
 {
     public abstract class ChannelFactory : CommunicationObject, IChannelFactory, IDisposable, IAsyncDisposable
     {
-        private string _configurationName;
         private ClientCredentials _readOnlyClientCredentials;
         private object _openLock = new object();
 
@@ -111,19 +110,6 @@ protected internal void EnsureOpened()
             }
         }
 
-        // configurationName can be:
-        // 1. null: don't bind any per-endpoint config (load common behaviors only)
-        // 2. "*" (wildcard): match any endpoint config provided there's exactly 1
-        // 3. anything else (including ""): match the endpoint config with the same name
-        protected virtual void ApplyConfiguration(string configurationName)
-        {
-            // This method is in the public contract but is not supported on CORECLR or NETNATIVE
-            if (!String.IsNullOrEmpty(configurationName))
-            {
-                throw ExceptionHelper.PlatformNotSupported();
-            }
-        }
-
         protected abstract ServiceEndpoint CreateDescription();
 
         internal EndpointAddress CreateEndpointAddress(ServiceEndpoint endpoint)
@@ -145,14 +131,7 @@ protected virtual IChannelFactory CreateFactory()
 
             if (Endpoint.Binding == null)
             {
-                if (_configurationName != null)
-                {
-                    throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(SRP.Format(SRP.SFxChannelFactoryNoBindingFoundInConfig1, _configurationName)));
-                }
-                else
-                {
-                    throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(SRP.SFxChannelFactoryNoBindingFoundInConfigOrCode));
-                }
+                throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(SRP.SFxChannelFactoryNoBindingFoundInConfigOrCode));
             }
 
             return ServiceChannelFactory.BuildChannelFactory(Endpoint, UseActiveAutoClose);
@@ -236,42 +215,20 @@ internal bool HasDuplexOperations()
             return false;
         }
 
-        protected void InitializeEndpoint(string configurationName, EndpointAddress address)
+        protected void InitializeEndpoint(EndpointAddress address)
         {
             Endpoint = CreateDescription();
-
-            ServiceEndpoint serviceEndpointFromConfig = null;
-
-            // Project N and K do not support System.Configuration, but this method is part of Windows Store contract.
-            // The configurationName==null path occurs in normal use.
-            if (configurationName != null)
-            {
-                throw ExceptionHelper.PlatformNotSupported();
-                // serviceEndpointFromConfig = ConfigLoader.LookupEndpoint(configurationName, address, this.serviceEndpoint.Contract);
-            }
-
-            if (serviceEndpointFromConfig != null)
+            if (address != null)
             {
-                Endpoint = serviceEndpointFromConfig;
+                Endpoint.Address = address;
             }
-            else
-            {
-                if (address != null)
-                {
-                    Endpoint.Address = address;
-                }
 
-                ApplyConfiguration(configurationName);
-            }
-            _configurationName = configurationName;
             EnsureSecurityCredentialsManager(Endpoint);
         }
 
         protected void InitializeEndpoint(ServiceEndpoint endpoint)
         {
             Endpoint = endpoint ?? throw DiagnosticUtility.ExceptionUtility.ThrowHelperArgumentNull(nameof(endpoint));
-
-            ApplyConfiguration(null);
             EnsureSecurityCredentialsManager(Endpoint);
         }
 
@@ -288,7 +245,6 @@ protected void InitializeEndpoint(Binding binding, EndpointAddress address)
                 Endpoint.Address = address;
             }
 
-            ApplyConfiguration(null);
             EnsureSecurityCredentialsManager(Endpoint);
         }
 
@@ -416,32 +372,7 @@ public ChannelFactory()
                 {
                     ServiceModelActivity.Start(activity, SRP.Format(SRP.ActivityConstructChannelFactory, typeof(TChannel).FullName), ActivityType.Construct);
                 }
-                InitializeEndpoint((string)null, null);
-            }
-        }
-
-        // TChannel provides ContractDescription, attr/config [TChannel,name] provides Address,Binding
-        public ChannelFactory(string endpointConfigurationName)
-            : this(endpointConfigurationName, null)
-        {
-        }
-
-        // TChannel provides ContractDescription, attr/config [TChannel,name] provides Binding, provide Address explicitly
-        public ChannelFactory(string endpointConfigurationName, EndpointAddress remoteAddress)
-            : this(typeof(TChannel))
-        {
-            using (ServiceModelActivity activity = DiagnosticUtility.ShouldUseActivity ? ServiceModelActivity.CreateBoundedActivity() : null)
-            {
-                if (DiagnosticUtility.ShouldUseActivity)
-                {
-                    ServiceModelActivity.Start(activity, SRP.Format(SRP.ActivityConstructChannelFactory, typeof(TChannel).FullName), ActivityType.Construct);
-                }
-                if (endpointConfigurationName == null)
-                {
-                    throw DiagnosticUtility.ExceptionUtility.ThrowHelperArgumentNull(nameof(endpointConfigurationName));
-                }
-
-                InitializeEndpoint(endpointConfigurationName, remoteAddress);
+                InitializeEndpoint((EndpointAddress)null);
             }
         }
 
@@ -615,21 +546,6 @@ private void ReflectOnCallbackInstance(ServiceEndpoint endpoint)
             }
         }
 
-        //Static funtions to create channels
-        protected static TChannel CreateChannel(String endpointConfigurationName)
-        {
-            ChannelFactory<TChannel> channelFactory = new ChannelFactory<TChannel>(endpointConfigurationName);
-
-            if (channelFactory.HasDuplexOperations())
-            {
-                throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidOperationException(SRP.Format(SRP.SFxInvalidStaticOverloadCalledForDuplexChannelFactory1, channelFactory._channelType.Name)));
-            }
-
-            TChannel channel = channelFactory.CreateChannel();
-            SetFactoryToAutoClose(channel);
-            return channel;
-        }
-
         public static TChannel CreateChannel(Binding binding, EndpointAddress endpointAddress)
         {
             ChannelFactory<TChannel> channelFactory = new ChannelFactory<TChannel>(binding, endpointAddress);

src/System.ServiceModel.Primitives/src/System/ServiceModel/ClientBase.cs

@@ -55,21 +55,6 @@ protected ClientBase()
             throw new PlatformNotSupportedException(SRP.ConfigurationFilesNotSupported);
         }
 
-        protected ClientBase(string endpointConfigurationName)
-        {
-            throw new PlatformNotSupportedException(SRP.ConfigurationFilesNotSupported);
-        }
-
-        protected ClientBase(string endpointConfigurationName, string remoteAddress)
-        {
-            throw new PlatformNotSupportedException(SRP.ConfigurationFilesNotSupported);
-        }
-
-        protected ClientBase(string endpointConfigurationName, EndpointAddress remoteAddress)
-        {
-            throw new PlatformNotSupportedException(SRP.ConfigurationFilesNotSupported);
-        }
-
         protected ClientBase(Binding binding, EndpointAddress remoteAddress)
         {
             if (binding == null)